Subzero: Basic Block Profiler.

pydir/szbuild.py

Index: pydir/szbuild.py
diff --git a/pydir/szbuild.py b/pydir/szbuild.py
index c962d4cfab443a37383ae5986882651819040266..4dc82a65eedbd615681d1b74970427548b2733e6 100755
--- a/pydir/szbuild.py
+++ b/pydir/szbuild.py
@@ -85,6 +85,9 @@ def AddOptionalArgs(argparser):
                            help='Output file type.  Default %(default)s.')
     argparser.add_argument('--sandbox', dest='sandbox', action='store_true',
                            help='Enabled sandboxing in the translator')
+    argparser.add_argument('--enable-block-profile', dest='enable_block_profile',

[Jim Stichnoth, 2015/06/08 23:45:31]

80-col

[John, 2015/06/09 15:36:17]

Done.

+                           action='store_true',
+                           help='Enabled Basic Block profiling.')

[Jim Stichnoth, 2015/06/08 23:45:30]

Enabled ==> Enable
and lowercase "basic block"

Also, can you fix "Enabled sandboxing" similarly? :)

[John, 2015/06/09 15:36:17]

Done.

     argparser.add_argument('--verbose', '-v', dest='verbose',
                            action='store_true',
                            help='Display some extra debugging output')
@@ -217,6 +220,7 @@ def ProcessPexe(args, pexe, exe):
                    '-ffunction-sections',
                    '-fdata-sections'] if hybrid else []) +
                  (['-sandbox'] if args.sandbox else []) +
+                 (['-enable-block-profile'] if args.enable_block_profile and not args.sandbox else []) +

[Jim Stichnoth, 2015/06/08 23:45:30]

80-col

[John, 2015/06/09 15:36:17]

Done.

                  args.sz_args +
                  [pexe],
                  echo=args.verbose)
@@ -307,9 +311,8 @@ def ProcessPexe(args, pexe, exe):
             '{ld} -m32 {partial} -o {exe} ' +
             # Keep the rest of this command line (except szrt_native_x8632.o) in
             # sync with RunHostLD() in pnacl-translate.py.
-            '{root}/toolchain/linux_x86/pnacl_newlib_raw/translator/' +
-            'x86-32-linux/lib/' +
-            '{{unsandboxed_irt,irt_random,irt_query_list}}.o ' +
+            '{root}/toolchain/linux_x86/pnacl_newlib/translator/x86-32-linux/' +

[Jim Stichnoth, 2015/06/08 23:45:31]

Please keep pnacl_newlib_raw instead of pnacl_newlib

[John, 2015/06/09 15:36:17]

Done.

+            'lib/{{unsandboxed_irt,irt_random,irt_query_list}}.o ' +
             '{root}/toolchain_build/src/subzero/build/runtime/' +
             'szrt_native_x8632.o -lpthread -lrt ' +
             '-Wl,--defsym=__Sz_AbsoluteZero=0'