Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1147013002: Set enable_hangouts_services_extension in build/common.gypi. (Closed)

Created:
5 years, 7 months ago by pbos
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set enable_hangouts_services_extension in build/common.gypi. This build flag used to be set from a repository that's going away, so enabling this flag for official builds has to be moved here. BUG=482123 R=kjellander@chromium.org,jochen@chromium.org,tommi@chromium.org Committed: https://crrev.com/72c3513416b5052a091914d77218854da415da48 Cr-Commit-Position: refs/heads/master@{#330927}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/common.gypi View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
pbos
PTAL
5 years, 7 months ago (2015-05-20 14:07:34 UTC) #1
kjellander_chromium
lgtm with comment about the comment https://codereview.chromium.org/1147013002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1147013002/diff/1/build/common.gypi#newcode2397 build/common.gypi:2397: # Enable the ...
5 years, 7 months ago (2015-05-20 15:47:03 UTC) #2
pbos
remove comment
5 years, 7 months ago (2015-05-20 17:23:34 UTC) #3
pbos
https://codereview.chromium.org/1147013002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1147013002/diff/1/build/common.gypi#newcode2397 build/common.gypi:2397: # Enable the Hangouts services extension for official builds. ...
5 years, 7 months ago (2015-05-20 17:23:54 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-21 07:49:58 UTC) #5
tommi (sloooow) - chröme
lgtm
5 years, 7 months ago (2015-05-21 08:43:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147013002/20001
5 years, 7 months ago (2015-05-21 08:43:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-21 10:29:56 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 10:30:44 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/72c3513416b5052a091914d77218854da415da48
Cr-Commit-Position: refs/heads/master@{#330927}

Powered by Google App Engine
This is Rietveld 408576698