Issue 11470031: Finish integrating logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11470031: Finish integrating logging. (Closed)

Created:
8 years ago by Bob Nystrom

Modified:
8 years ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Finish integrating logging. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15877

Patch Set 2 : Remove merge error. #

Patch Set 3 : Respond to review. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -55 lines)			Patch
M	utils/pub/command_lish.dart	View	1	4 chunks	+7 lines, -5 lines	0 comments	Download
M	utils/pub/curl_client.dart	View		4 chunks	+7 lines, -0 lines	0 comments	Download
M	utils/pub/entrypoint.dart	View		5 chunks	+9 lines, -2 lines	0 comments	Download
M	utils/pub/io.dart	View	1 2	29 chunks	+116 lines, -33 lines	0 comments	Download
M	utils/pub/oauth2.dart	View		6 chunks	+27 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/11470031/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/11470031/diff/1/utils/pub/io.dart#newcode565 utils/pub/io.dart:565: log.io("Sending HTTP request $request."); Add a TODO to ...

8 years ago (2012-12-08 03:09:27 UTC) #2

Bob Nystrom

8 years ago (2012-12-08 03:13:45 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11470031/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/11470031/diff/1/utils/pub/io.dart#newcode565
utils/pub/io.dart:565: log.io("Sending HTTP request $request.");
On 2012/12/08 03:09:27, nweiz wrote:
> Add a TODO to print the request body when it's available and plain text.

Done.

https://codereview.chromium.org/11470031/diff/1/utils/pub/io.dart#newcode981
utils/pub/io.dart:981: contents.forEach(log.fine);
On 2012/12/08 03:09:27, nweiz wrote:
> Add these to a buffer and print them as one message.

Done.