Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: utils/tests/pub/test_pub.dart

Issue 11470030: Work around issue 7218 in Pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Bug fixes. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/io.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/test_pub.dart
diff --git a/utils/tests/pub/test_pub.dart b/utils/tests/pub/test_pub.dart
index 846a21514b049b433b1ca1fccad0904f60516a6e..18338316de78123a3db38630ef5a7b8cf7d9b1dd 100644
--- a/utils/tests/pub/test_pub.dart
+++ b/utils/tests/pub/test_pub.dart
@@ -1334,8 +1334,8 @@ class ScheduledProcess {
/// Wraps a [Process] [Future] in a scheduled process.
ScheduledProcess(this.name, Future<Process> process)
: _process = process,
- _stdout = process.transform((p) => _wrapStream(p.stdout)),
- _stderr = process.transform((p) => _wrapStream(p.stderr)) {
+ _stdout = process.transform((p) => new StringInputStream(p.stdout)),
+ _stderr = process.transform((p) => new StringInputStream(p.stderr)) {
_schedule((_) {
if (!_endScheduled) {
@@ -1466,12 +1466,6 @@ class ScheduledProcess {
});
}
- /// Wraps [source] and ensures it gets eagerly drained. We do this to make
- /// sure a process will exit even if we don't care about its output.
- static StringInputStream _wrapStream(InputStream source) {
- return new StringInputStream(wrapInputStream(source));
- }
-
/// Prints the remaining data in the process's stdout and stderr streams.
/// Prints nothing if the straems are empty.
Future _printStreams() {
« no previous file with comments | « utils/pub/io.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698