[Android] Add screenshot command line tool.

[Android] Add screenshot command line tool.

This modifies the no longer used monkeyrunner_screenshot.py into a
simple screenshot tool.

BUG=164644

[newt (away), 2012-12-06 20:54:21]

PTAL

[nyquist, 2012-12-06 21:19:22]

lgtm

[newt (away), 2012-12-06 21:27:27]

+jcivelli for full committer magic stamp

[frankf, 2012-12-06 21:44:42]

nits.

https://codereview.chromium.org/11470004/diff/1/build/android/screenshot.py
File build/android/screenshot.py (right):

https://codereview.chromium.org/11470004/diff/1/build/android/screenshot.py#n...
build/android/screenshot.py:20: from pylib import android_commands
Two blank lines here.

https://codereview.chromium.org/11470004/diff/1/build/android/screenshot.py#n...
build/android/screenshot.py:25: parser.add_option("-s", "--serial",
dest="serial",
Use single quotes for consistency.

[newt (away), 2012-12-06 21:49:25]

comments addressed

[frankf, 2012-12-06 21:50:14]

LGTM with a question.

https://codereview.chromium.org/11470004/diff/1/build/android/screenshot.py
File build/android/screenshot.py (right):

https://codereview.chromium.org/11470004/diff/1/build/android/screenshot.py#n...
build/android/screenshot.py:25: parser.add_option("-s", "--serial",
dest="serial",
Also, how does this behave if no serial is given and multiple devices are
attached?

[Jay Civelli, 2012-12-06 22:10:41]

lgtm

[newt (away), 2012-12-06 22:16:59]

On 2012/12/06 21:50:14, frankf wrote:
> LGTM with a question.
> 
> https://codereview.chromium.org/11470004/diff/1/build/android/screenshot.py
> File build/android/screenshot.py (right):
> 
>
https://codereview.chromium.org/11470004/diff/1/build/android/screenshot.py#n...
> build/android/screenshot.py:25: parser.add_option("-s", "--serial",
> dest="serial",
> Also, how does this behave if no serial is given and multiple devices are
> attached?

The adb commands fail silently but you get an AssertionError afterwards at
"assert os.path.exists(host_file)" in android_commands.py (unless the
destination file happens to already exist).

I added an error message to hopefully prevent people from being confused by this
situation.  Since this is only run manually, I think that should be sufficient.

[frankf, 2012-12-06 22:27:09]

https://codereview.chromium.org/11470004/diff/1004/build/android/screenshot.py
File build/android/screenshot.py (right):

https://codereview.chromium.org/11470004/diff/1004/build/android/screenshot.p...
build/android/screenshot.py:40: print ('Screenshot failed. If multiple devices
are attached, be sure to '
Actually, it'd be cleaner do explicitly check using len(GetAttachedDevices()) to
avoid a red herring suggestion.

[newt (away), 2012-12-06 22:32:29]

https://codereview.chromium.org/11470004/diff/1004/build/android/screenshot.py
File build/android/screenshot.py (right):

https://codereview.chromium.org/11470004/diff/1004/build/android/screenshot.p...
build/android/screenshot.py:40: print ('Screenshot failed. If multiple devices
are attached, be sure to '
On 2012/12/06 22:27:09, frankf wrote:
> Actually, it'd be cleaner do explicitly check using len(GetAttachedDevices())
to
> avoid a red herring suggestion.
Exactly.  Tommy had the same idea.  Done.

[frankf, 2012-12-06 22:37:47]

https://codereview.chromium.org/11470004/diff/11001/build/android/screenshot.py
File build/android/screenshot.py (right):

https://codereview.chromium.org/11470004/diff/11001/build/android/screenshot....
build/android/screenshot.py:34: if options.serial is None and
len(android_commands.GetAttachedDevices()) > 1:
if not options.serial and len(android_commands.GetAttachedDevices()) > 1:
  parser.error('Multiple...')

[newt (away), 2012-12-06 22:41:21]

https://codereview.chromium.org/11470004/diff/11001/build/android/screenshot.py
File build/android/screenshot.py (right):

https://codereview.chromium.org/11470004/diff/11001/build/android/screenshot....
build/android/screenshot.py:34: if options.serial is None and
len(android_commands.GetAttachedDevices()) > 1:
On 2012/12/06 22:37:47, frankf wrote:
> if not options.serial and len(android_commands.GetAttachedDevices()) > 1:
>   parser.error('Multiple...')

Done.

[newt (away), 2012-12-06 23:21:07]

committed via git cl dcommit as r171615