Issue 1146983004: Avoid creating GrGLPath to the resource cache when creating GrGLPathRanges

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1146983004: Avoid creating GrGLPath to the resource cache when creating GrGLPathRanges (Closed)

Created:
5 years, 7 months ago by Kimmo Kinnunen

Modified:
5 years, 7 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org, Chris Dalton

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Avoid creating GrGLPath to the resource cache when creating GrGLPathRanges Do not create a GrGLPath when loading glyphs with the driver and creating GrGLPathRange based on those. The path would be inserted to the GPU resource cache and then immediately be released. Instead, just init the first path object of the path range as the template. Committed: https://skia.googlesource.com/skia/+/61e91966aaa2b42ade8a74229abd9a3304ce2003

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/gpu/gl/GrGLPathRendering.cpp	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146983004/1

5 years, 7 months ago (2015-05-25 05:06:48 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-25 05:12:25 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/61e91966aaa2b42ade8a74229abd9a3304ce2003

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages