Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1146953003: Split SetConcatMatrix44Bench to cover both internal paths. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
yang.zhang, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Split SetConcatMatrix44Bench to cover both internal paths. The existing bench only tests the fast path, but we're looking to speed up the general case. It'd be nice to be able to measure that speedup. BUG=skia: Committed: https://skia.googlesource.com/skia/+/c6c6a91ff2356163d9abf9233ff0f025738940f8

Patch Set 1 #

Patch Set 2 : slow -> general #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M bench/Matrix44Bench.cpp View 1 3 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mtklein_C
5 years, 6 months ago (2015-06-08 14:04:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146953003/20001
5 years, 6 months ago (2015-06-08 14:04:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-08 14:10:29 UTC) #6
yang.zhang
After testing, the new bench can cover both the fast path and the general case. ...
5 years, 6 months ago (2015-06-09 08:53:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146953003/20001
5 years, 6 months ago (2015-06-09 11:41:41 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 6 months ago (2015-06-09 11:41:43 UTC) #10
mtklein
lgtm
5 years, 6 months ago (2015-06-09 11:42:26 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 11:44:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c6c6a91ff2356163d9abf9233ff0f025738940f8

Powered by Google App Engine
This is Rietveld 408576698