Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1146933002: Turn on warnings for usage of disabled V8 APIs (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
vogelheim
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/standalone.gypi View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-20 07:46:36 UTC) #1
vogelheim
lgtm
5 years, 7 months ago (2015-05-20 07:49:08 UTC) #2
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-20 08:07:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b190fc2214b2926873b342a39a85c27dc234ae1f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698