Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 114693005: IDL compiler: sync Python to r164407 (Closed)

Created:
6 years, 11 months ago by Nils Barth (inactive)
Modified:
6 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: sync Python to r164407 Python side to: Remove custom signatures from V8 bindings https://codereview.chromium.org/109473008/ BUG=239771 TBR=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164488

Patch Set 1 #

Patch Set 2 : Simpler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -42 lines) Patch
M Source/bindings/scripts/unstable/v8_methods.py View 1 5 chunks +2 lines, -33 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
6 years, 11 months ago (2014-01-06 02:26:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/114693005/30001
6 years, 11 months ago (2014-01-06 02:26:27 UTC) #2
haraken
LGTM
6 years, 11 months ago (2014-01-06 02:56:18 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 04:34:16 UTC) #4
Message was sent while issue was closed.
Change committed as 164488

Powered by Google App Engine
This is Rietveld 408576698