Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1146923004: Throw illegal exception when formatting with invalid template index. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Throw illegal exception when formatting with invalid template index. R=arv@chromium.org BUG=chromium:492526 LOG=N Committed: https://crrev.com/dc9f0d46425b5be5b34e7ed75a4914600bccb04c Cr-Commit-Position: refs/heads/master@{#28671}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M src/messages.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-492526.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 7 months ago (2015-05-27 14:00:36 UTC) #1
arv (Not doing code reviews)
LGTM
5 years, 7 months ago (2015-05-27 14:07:11 UTC) #2
Igor Sheludko
https://codereview.chromium.org/1146923004/diff/1/src/messages.cc File src/messages.cc (right): https://codereview.chromium.org/1146923004/diff/1/src/messages.cc#newcode328 src/messages.cc:328: break; DBC: do we still need break here?
5 years, 7 months ago (2015-05-27 14:16:17 UTC) #4
arv (Not doing code reviews)
https://codereview.chromium.org/1146923004/diff/1/src/messages.cc File src/messages.cc (right): https://codereview.chromium.org/1146923004/diff/1/src/messages.cc#newcode328 src/messages.cc:328: break; On 2015/05/27 14:16:17, Igor Sheludko wrote: > DBC: ...
5 years, 7 months ago (2015-05-27 14:16:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146923004/20001
5 years, 6 months ago (2015-05-28 06:39:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-05-28 07:05:07 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 07:05:22 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc9f0d46425b5be5b34e7ed75a4914600bccb04c
Cr-Commit-Position: refs/heads/master@{#28671}

Powered by Google App Engine
This is Rietveld 408576698