Handle redirects in AuthenticatingURLLoaderImpl.

services/authenticating_url_loader/authenticating_url_loader_impl.cc

Index: services/authenticating_url_loader/authenticating_url_loader_impl.cc
diff --git a/services/authenticating_url_loader/authenticating_url_loader_impl.cc b/services/authenticating_url_loader/authenticating_url_loader_impl.cc
index 9d839afdca9c5b75fc50ef6174553e171cfbc641..d83ee243d5b6ed057853d83b41c7a411166c33b6 100644
--- a/services/authenticating_url_loader/authenticating_url_loader_impl.cc
+++ b/services/authenticating_url_loader/authenticating_url_loader_impl.cc
@@ -42,10 +42,17 @@ void AuthenticatingURLLoaderImpl::Start(
   auto_follow_redirects_ = request->auto_follow_redirects;
   bypass_cache_ = request->bypass_cache;
   headers_ = request->headers.Clone();
-  pending_start_callback_ = callback;
+  pending_request_callback_ = callback;
   StartNetworkRequest(request.Pass());
 }
 
+void AuthenticatingURLLoaderImpl::FollowRedirect(
+    const Callback<void(URLResponsePtr)>& callback) {
+  DCHECK(!auto_follow_redirects_);

[qsr, 2015/05/27 14:29:36]

You should not dcheck on a wrong usage of your API. Just return a null response.

[blundell, 2015/06/03 10:55:11]

Done.

+  pending_request_callback_ = callback;
+  FollowRedirectInternal();
+}
+
 void AuthenticatingURLLoaderImpl::StartNetworkRequest(URLRequestPtr request) {
   network_service_->CreateURLLoader(mojo::GetProxy(&url_loader_));
   url_loader_->Start(request.Pass(),
@@ -59,10 +66,26 @@ void AuthenticatingURLLoaderImpl::OnConnectionError() {
 }
 
 void AuthenticatingURLLoaderImpl::OnLoadComplete(URLResponsePtr response) {
+  if (response->redirect_url) {
+    url_ = response->redirect_url;
+    username_ = nullptr;
+    request_authorization_state_ = REQUEST_NOT_AUTHORIZED;
+
+    if (auto_follow_redirects_) {
+      FollowRedirectInternal();
+    } else {
+      // NOTE: We do not reset |url_loader_| here as it will be needed if the
+      // client calls |FollowRedirect()|.
+      pending_request_callback_.Run(response.Pass());
+    }
+    return;
+  }
+
   url_loader_.reset();
+
   if (response->status_code != 401 || !authentication_service_ ||
       request_authorization_state_ == REQUEST_AUTHORIZED_WITH_FRESH_TOKEN) {
-    pending_start_callback_.Run(response.Pass());
+    pending_request_callback_.Run(response.Pass());
     return;
   }
 
@@ -88,11 +111,21 @@ void AuthenticatingURLLoaderImpl::OnLoadComplete(URLResponsePtr response) {
   OnAccountSelected(username_, String());
 }
 
+void AuthenticatingURLLoaderImpl::FollowRedirectInternal() {
+  DCHECK(url_);
+  DCHECK(url_loader_);
+  DCHECK(!username_);
+  DCHECK(request_authorization_state_ == REQUEST_NOT_AUTHORIZED);
+
+  url_loader_->FollowRedirect(base::Bind(
+      &AuthenticatingURLLoaderImpl::OnLoadComplete, base::Unretained(this)));
+}
+
 void AuthenticatingURLLoaderImpl::OnAccountSelected(String username,
                                                     String error) {
   if (error) {
     LOG(ERROR) << "Error (" << error << ") while selecting account";
-    pending_start_callback_.Run(pending_response_.Pass());
+    pending_request_callback_.Run(pending_response_.Pass());
     return;
   }
 
@@ -112,7 +145,7 @@ void AuthenticatingURLLoaderImpl::OnOAuth2TokenReceived(String token,
                                                         String error) {
   if (error) {
     LOG(ERROR) << "Error (" << error << ") while getting token";
-    pending_start_callback_.Run(pending_response_.Pass());
+    pending_request_callback_.Run(pending_response_.Pass());
     return;
   }
 
@@ -125,7 +158,7 @@ void AuthenticatingURLLoaderImpl::OnOAuth2TokenReceived(String token,
 
   URLRequestPtr request(mojo::URLRequest::New());
   request->url = url_;
-  request->auto_follow_redirects = auto_follow_redirects_;
+  request->auto_follow_redirects = false;
   request->bypass_cache = bypass_cache_;
   request->headers = headers.Pass();
 
@@ -139,8 +172,8 @@ void AuthenticatingURLLoaderImpl::SetAuthenticationService(
     return;
 
   // We need authentication but have no AuthenticationService.
-  DCHECK(!pending_start_callback_.is_null());
-  pending_start_callback_.Run(pending_response_.Pass());
+  DCHECK(!pending_request_callback_.is_null());
+  pending_request_callback_.Run(pending_response_.Pass());
 }
 
 }  // namespace mojo