Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1146913008: Revert of media: Simplify {Audio|Video}Decoder initialization callback. (Closed)

Created:
5 years, 6 months ago by Nicolas Zea
Modified:
5 years, 6 months ago
Reviewers:
watk, xhwang, DaleCurtis
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media: Simplify {Audio|Video}Decoder initialization callback. (patchset #3 id:40001 of https://codereview.chromium.org/1156643007/) Reason for revert: Compile failure on mac: http://build.chromium.org/p/chromium/buildstatus?builder=Mac&number=3225 Original issue's description: > media: Simplify {Audio|Video}Decoder initialization callback. > > Use base::Callback<void(bool)> instead of a PipelineStatusCB for decoder initialization where PipelineStatus is not really relevant. This helps clean up unnecessary uses of PipelineStatusCB so in the future we could plumb more info in PipelineStatusCB (e.g. error messages) to help debugging/testing. > > TBR=bbudge@chromium.org > BUG=126070 > TEST=Updated unittests. > > Committed: https://crrev.com/cb8f0c2260d44d6610a4c157b70c01cda1f50913 > Cr-Commit-Position: refs/heads/master@{#333127} TBR=watk@chromium.org,dalecurtis@chromium.org,xhwang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=126070 Committed: https://crrev.com/e51969862119f6a721ec5299e41f01cd3df5fd4a Cr-Commit-Position: refs/heads/master@{#333137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -206 lines) Patch
M content/renderer/pepper/video_decoder_shim.cc View 3 chunks +16 lines, -4 lines 0 comments Download
M media/base/audio_decoder.h View 2 chunks +4 lines, -7 lines 0 comments Download
M media/base/mock_filters.h View 2 chunks +5 lines, -6 lines 0 comments Download
M media/base/test_helpers.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/test_helpers.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M media/base/video_decoder.h View 3 chunks +5 lines, -8 lines 0 comments Download
M media/filters/audio_decoder_selector_unittest.cc View 7 chunks +18 lines, -9 lines 0 comments Download
M media/filters/audio_decoder_unittest.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M media/filters/decoder_selector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/decoder_selector.cc View 2 chunks +11 lines, -10 lines 0 comments Download
M media/filters/decoder_stream.h View 3 chunks +2 lines, -4 lines 0 comments Download
M media/filters/decoder_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decoder_stream_traits.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/filters/decoder_stream_traits.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/filters/decrypting_audio_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_audio_decoder.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M media/filters/decrypting_audio_decoder_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M media/filters/decrypting_video_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_video_decoder.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M media/filters/decrypting_video_decoder_unittest.cc View 8 chunks +18 lines, -13 lines 0 comments Download
M media/filters/fake_video_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/fake_video_decoder.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/filters/fake_video_decoder_unittest.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 11 chunks +16 lines, -14 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 4 chunks +12 lines, -14 lines 0 comments Download
M media/filters/opus_audio_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/opus_audio_decoder.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/filters/video_decoder_selector_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M media/filters/vpx_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/vpx_video_decoder.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 2 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nicolas Zea
Created Revert of media: Simplify {Audio|Video}Decoder initialization callback.
5 years, 6 months ago (2015-06-05 21:27:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146913008/1
5 years, 6 months ago (2015-06-05 21:27:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 21:30:26 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 21:31:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e51969862119f6a721ec5299e41f01cd3df5fd4a
Cr-Commit-Position: refs/heads/master@{#333137}

Powered by Google App Engine
This is Rietveld 408576698