Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2309)

Issue 1146913005: Give the Stocks2 App a new improved toolbar. (Closed)

Created:
5 years, 6 months ago by eseidel
Modified:
5 years, 6 months ago
Reviewers:
Hixie, abarth-chromium
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Give the Stocks2 App a new improved toolbar. Looks horrible. But it's a start. R=abarth@chromium.org, ianh@google.com BUG= Committed: https://chromium.googlesource.com/external/mojo/+/957a327b6dcd141ee2b4c93b38ef5bdc3eb972fd

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -91 lines) Patch
M sky/engine/core/painting/Size.dart View 1 chunk +3 lines, -0 lines 1 comment Download
M sky/examples/stocks2/lib/stock_app.dart View 4 chunks +28 lines, -26 lines 1 comment Download
M sky/sdk/lib/framework/components2/icon.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M sky/sdk/lib/framework/components2/icon_button.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/components2/tool_bar.dart View 1 chunk +23 lines, -19 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 2 chunks +1 line, -38 lines 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 2 chunks +10 lines, -1 line 1 comment Download
M sky/sdk/lib/framework/theme/colors.dart View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eseidel
5 years, 6 months ago (2015-06-02 23:05:51 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/1146913005/diff/1/sky/engine/core/painting/Size.dart File sky/engine/core/painting/Size.dart (right): https://codereview.chromium.org/1146913005/diff/1/sky/engine/core/painting/Size.dart#newcode17 sky/engine/core/painting/Size.dart:17: const Size.onlyHeight(this.height) : width = 0.0; We don't ...
5 years, 6 months ago (2015-06-02 23:09:04 UTC) #2
eseidel
Committed patchset #1 (id:1) manually as 957a327b6dcd141ee2b4c93b38ef5bdc3eb972fd (presubmit successful).
5 years, 6 months ago (2015-06-02 23:13:37 UTC) #3
Hixie
5 years, 6 months ago (2015-06-03 17:31:41 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/1146913005/diff/1/sky/examples/stocks2/lib/st...
File sky/examples/stocks2/lib/stock_app.dart (right):

https://codereview.chromium.org/1146913005/diff/1/sky/examples/stocks2/lib/st...
sky/examples/stocks2/lib/stock_app.dart:167: center: new Text('Stocks'),
Add a comment here referencing _titleStyle, so we don't forget to use it.

Powered by Google App Engine
This is Rietveld 408576698