OLD | NEW |
---|---|
1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #ifndef CONTENT_BROWSER_BAD_MESSAGE_H_ | 5 #ifndef CONTENT_BROWSER_BAD_MESSAGE_H_ |
6 #define CONTENT_BROWSER_BAD_MESSAGE_H_ | 6 #define CONTENT_BROWSER_BAD_MESSAGE_H_ |
7 | 7 |
8 namespace content { | 8 namespace content { |
9 class BrowserMessageFilter; | 9 class BrowserMessageFilter; |
10 class RenderProcessHost; | 10 class RenderProcessHost; |
11 | 11 |
12 namespace bad_message { | 12 namespace bad_message { |
13 | 13 |
14 // The browser process often chooses to terminate a renderer if it receives | 14 // The browser process often chooses to terminate a renderer if it receives |
15 // a bad IPC message. The reasons are tracked for metrics. | 15 // a bad IPC message. The reasons are tracked for metrics. |
16 // | 16 // |
17 // Content embedders should implement their own bad message statistics but | 17 // Content embedders should implement their own bad message statistics but |
18 // should use similar histogram names to make analysis easier. | 18 // should use similar histogram names to make analysis easier. |
19 // | 19 // |
20 // NOTE: Do not remove or reorder elements in this list. Add new entries at the | 20 // NOTE: Do not remove or reorder elements in this list. Add new entries at the |
21 // end. Items may be renamed but do not change the values. We rely on the enum | 21 // end. Items may be renamed but do not change the values. We rely on the enum |
22 // values in histograms. Also update histograms.xml with any new values by | 22 // values in histograms. Also update histograms.xml with any new values by |
23 // running: | 23 // running: |
24 // python tools/metrics/histograms/update_bad_message_reasons.py | 24 // python tools/metrics/histograms/update_bad_message_reasons.py |
Mike West
2015/06/10 09:34:18
I don't think you did this.
jungkees
2015/06/10 14:10:28
Updated. Thanks.
| |
25 enum BadMessageReason { | 25 enum BadMessageReason { |
26 NC_IN_PAGE_NAVIGATION = 0, | 26 NC_IN_PAGE_NAVIGATION = 0, |
27 RFH_CAN_COMMIT_URL_BLOCKED = 1, | 27 RFH_CAN_COMMIT_URL_BLOCKED = 1, |
28 RFH_CAN_ACCESS_FILES_OF_PAGE_STATE = 2, | 28 RFH_CAN_ACCESS_FILES_OF_PAGE_STATE = 2, |
29 RFH_SANDBOX_FLAGS = 3, | 29 RFH_SANDBOX_FLAGS = 3, |
30 RFH_NO_PROXY_TO_PARENT = 4, | 30 RFH_NO_PROXY_TO_PARENT = 4, |
31 RPH_DESERIALIZATION_FAILED = 5, | 31 RPH_DESERIALIZATION_FAILED = 5, |
32 RVH_CAN_ACCESS_FILES_OF_PAGE_STATE = 6, | 32 RVH_CAN_ACCESS_FILES_OF_PAGE_STATE = 6, |
33 RVH_FILE_CHOOSER_PATH = 7, | 33 RVH_FILE_CHOOSER_PATH = 7, |
34 RWH_SYNTHETIC_GESTURE = 8, | 34 RWH_SYNTHETIC_GESTURE = 8, |
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
96 SWDH_TERMINATE_BAD_HANDLE = 70, | 96 SWDH_TERMINATE_BAD_HANDLE = 70, |
97 FAMF_APPEND_ITEM_TO_BLOB = 71, | 97 FAMF_APPEND_ITEM_TO_BLOB = 71, |
98 FAMF_APPEND_SHARED_MEMORY_TO_BLOB = 72, | 98 FAMF_APPEND_SHARED_MEMORY_TO_BLOB = 72, |
99 FAMF_MALFORMED_STREAM_URL = 73, | 99 FAMF_MALFORMED_STREAM_URL = 73, |
100 FAMF_APPEND_ITEM_TO_STREAM = 74, | 100 FAMF_APPEND_ITEM_TO_STREAM = 74, |
101 FAMF_APPEND_SHARED_MEMORY_TO_STREAM = 75, | 101 FAMF_APPEND_SHARED_MEMORY_TO_STREAM = 75, |
102 IDBDH_CAN_READ_FILE = 76, | 102 IDBDH_CAN_READ_FILE = 76, |
103 IDBDH_GET_OR_TERMINATE = 77, | 103 IDBDH_GET_OR_TERMINATE = 77, |
104 RMF_SET_COOKIE_BAD_ORIGIN = 78, | 104 RMF_SET_COOKIE_BAD_ORIGIN = 78, |
105 RMF_GET_COOKIES_BAD_ORIGIN = 79, | 105 RMF_GET_COOKIES_BAD_ORIGIN = 79, |
106 SWDH_GET_REGISTRATIONS_NO_HOST = 80, | |
107 SWDH_GET_REGISTRATIONS_INVALID_ORIGIN = 81, | |
106 // Please add new elements here. The naming convention is abbreviated class | 108 // Please add new elements here. The naming convention is abbreviated class |
107 // name (e.g. RenderFrameHost becomes RFH) plus a unique description of the | 109 // name (e.g. RenderFrameHost becomes RFH) plus a unique description of the |
108 // reason. | 110 // reason. |
109 BAD_MESSAGE_MAX | 111 BAD_MESSAGE_MAX |
110 }; | 112 }; |
111 | 113 |
112 // Called when the browser receives a bad IPC message from a renderer process on | 114 // Called when the browser receives a bad IPC message from a renderer process on |
113 // the UI thread. Logs the event, records a histogram metric for the |reason|, | 115 // the UI thread. Logs the event, records a histogram metric for the |reason|, |
114 // and terminates the process for |host|. | 116 // and terminates the process for |host|. |
115 void ReceivedBadMessage(RenderProcessHost* host, BadMessageReason reason); | 117 void ReceivedBadMessage(RenderProcessHost* host, BadMessageReason reason); |
116 | 118 |
117 // Called when a browser message filter receives a bad IPC message from a | 119 // Called when a browser message filter receives a bad IPC message from a |
118 // renderer or other child process. Logs the event, records a histogram metric | 120 // renderer or other child process. Logs the event, records a histogram metric |
119 // for the |reason|, and terminates the process for |filter|. | 121 // for the |reason|, and terminates the process for |filter|. |
120 void ReceivedBadMessage(BrowserMessageFilter* filter, BadMessageReason reason); | 122 void ReceivedBadMessage(BrowserMessageFilter* filter, BadMessageReason reason); |
121 | 123 |
122 } // namespace bad_message | 124 } // namespace bad_message |
123 } // namespace content | 125 } // namespace content |
124 | 126 |
125 #endif // CONTENT_BROWSER_BAD_MESSAGE_H_ | 127 #endif // CONTENT_BROWSER_BAD_MESSAGE_H_ |
OLD | NEW |