Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1146913002: Change hash table capacity defaults. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Change hash table capacity defaults. The rationale is: callsites of HashTable::New without the capacity_option argument specify an initial size of the hash table. It's surprising that it's automatically doubled. This does not change the size of the slow mode object property dictionary, as it allocates via Dictionary::New. BUG=chromium:481129 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M src/api-natives.h View 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 3 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Yang
The rationale is: callsites of HashTable::New without the capacity_option argument specify an initial size of ...
5 years, 7 months ago (2015-05-20 12:18:49 UTC) #2
mvstanton
lgtm. nit: add that nice rationale to the CL description so it's in the tree ...
5 years, 7 months ago (2015-05-20 12:36:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146913002/1
5 years, 7 months ago (2015-05-20 13:21:57 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 14:10:12 UTC) #7
Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/545)

Powered by Google App Engine
This is Rietveld 408576698