Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: webkit/media/webmediaplayer_proxy.cc

Issue 11469040: EME v0.1: Report defaultURL in KeyMessage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/media/webmediaplayer_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/webmediaplayer_proxy.cc
diff --git a/webkit/media/webmediaplayer_proxy.cc b/webkit/media/webmediaplayer_proxy.cc
index 13941bf2ad6b5518e57fabf3e200562119889c5e..13efcfa034f7ef6fe4e8d6a33ac11f1278de902b 100644
--- a/webkit/media/webmediaplayer_proxy.cc
+++ b/webkit/media/webmediaplayer_proxy.cc
@@ -166,9 +166,14 @@ void WebMediaPlayerProxy::KeyMessageTask(const std::string& key_system,
int message_length,
const std::string& default_url) {
DCHECK(render_loop_->BelongsToCurrentThread());
- if (webmediaplayer_)
+ if (webmediaplayer_) {
+ const GURL default_url_gurl(default_url);
+ DLOG_IF(WARNING, !default_url.empty() && !default_url_gurl.is_valid())
+ << "Invalid URL in default_url: " << default_url.c_str();
xhwang 2012/12/08 01:16:44 do you need c_str() here?
ddorwin 2012/12/08 01:20:58 Yes. Without it, no newline is added and all text
scherkus (not reviewing) 2012/12/11 21:07:43 huh? what text following default_str?
ddorwin 2012/12/14 20:52:27 Removed. Bug in the sample code. I updated cdm.h s
webmediaplayer_->OnKeyMessage(key_system, session_id,
- message.Pass(), message_length, default_url);
+ message.Pass(), message_length,
+ default_url_gurl);
+ }
}
void WebMediaPlayerProxy::NeedKeyTask(const std::string& key_system,
« no previous file with comments | « webkit/media/webmediaplayer_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698