Issue 1146903003: Allow timer heap updates on firing shared timer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1146903003: Allow timer heap updates on firing shared timer. (Closed)

Created:
5 years, 7 months ago by sof

Modified:
5 years, 7 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Allow timer heap updates on firing shared timer. Follow up the ASan exemptions from r195613 and allow timer heap updates while servicing the shared timer callback. The Timer implementation of fired() already checks that no access of near-dead objects is done. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195620

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	Source/platform/ThreadTimers.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

Please take a look. Need this exemption also, quite clearly :-) https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oilpan_ASAN/1338/layout-test-results/results.html

5 years, 7 months ago (2015-05-20 13:23:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146903003/1

5 years, 7 months ago (2015-05-20 13:53:34 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-20 14:37:49 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195620

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages