chromeos/network/onc/onc_normalizer.h - Issue 11469026: Extending ONC validator's logging. Completing toplevel validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_normalizer.h

Issue 11469026: Extending ONC validator's logging. Completing toplevel validation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@add_error_handling_to_validator

Patch Set: Rebased. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromeos/network/onc/onc_normalizer.h

diff --git a/chromeos/network/onc/onc_normalizer.h b/chromeos/network/onc/onc_normalizer.h

index 5d00f00b962016545695ee3fd850f5a02cab0b99..0b4468b1f7c8ac21e4583ab2c6ac6fbe3ba32c72 100644

--- a/chromeos/network/onc/onc_normalizer.h

+++ b/chromeos/network/onc/onc_normalizer.h

@@ -33,7 +33,8 @@ class CHROMEOS_EXPORT Normalizer : public Mapper {

// Dispatch to the right normalization function according to |signature|.

virtual scoped_ptr<base::DictionaryValue> MapObject(

const OncValueSignature& signature,

- const base::DictionaryValue& onc_object) OVERRIDE;

+ const base::DictionaryValue& onc_object,

+ bool* error) OVERRIDE;

void NormalizeIPsec(base::DictionaryValue* ipsec);

void NormalizeVPN(base::DictionaryValue* vpn);

« no previous file with comments | « chromeos/network/onc/onc_merger_unittest.cc ('k') | chromeos/network/onc/onc_normalizer.cc » ('j') | no next file with comments »