chrome/browser/policy/configuration_policy_handler.cc - Issue 11469026: Extending ONC validator's logging. Completing toplevel validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/configuration_policy_handler.cc

Issue 11469026: Extending ONC validator's logging. Completing toplevel validation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@add_error_handling_to_validator

Patch Set: Rebased (don't reject policies by onc::Validator). Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/browser/chromeos/cros/network_library_impl_base.cc ('k') | chrome/browser/policy/configuration_policy_handler_chromeos.cc » ('j') | chromeos/network/onc/onc_validator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/configuration_policy_handler.cc

diff --git a/chrome/browser/policy/configuration_policy_handler.cc b/chrome/browser/policy/configuration_policy_handler.cc

index d4c22bf3d7854ec7b3e022c4ca56afd78287527b..01b58d993111f692cd630bff64391f14a0e1ae50 100644

--- a/chrome/browser/policy/configuration_policy_handler.cc

+++ b/chrome/browser/policy/configuration_policy_handler.cc

@@ -121,7 +121,7 @@ std::string ValueTypeToString(Value::Type type) {

"dictionary",

"list"

};

- DCHECK(static_cast<size_t>(type) < arraysize(strings));

+ CHECK(static_cast<size_t>(type) < arraysize(strings));

return std::string(strings[type]);

}