chrome/browser/policy/network_configuration_updater_unittest.cc - Issue 11469026: Extending ONC validator's logging. Completing toplevel validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/network_configuration_updater_unittest.cc

Issue 11469026: Extending ONC validator's logging. Completing toplevel validation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@add_error_handling_to_validator

Patch Set: Rebased (Greg moved ONC tools to chromeos/network/onc/). Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/policy/configuration_policy_handler_chromeos.cc ('K') | « chrome/browser/policy/network_configuration_updater.cc ('k') | chrome/browser/ui/webui/net_internals/net_internals_ui.cc » ('j') | chromeos/network/onc/onc_mapper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/network_configuration_updater_unittest.cc

diff --git a/chrome/browser/policy/network_configuration_updater_unittest.cc b/chrome/browser/policy/network_configuration_updater_unittest.cc

index e1c120f291c7efe83e3df92c6ab1a505e6e63e1c..6e94bb41988bde7b4c92c5efa9abde7ea2ee171b 100644

--- a/chrome/browser/policy/network_configuration_updater_unittest.cc

+++ b/chrome/browser/policy/network_configuration_updater_unittest.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/policy/policy_map.h"

#include "chrome/browser/policy/policy_service_impl.h"

#include "chromeos/network/onc/onc_constants.h"

+#include "chromeos/network/onc/onc_utils.h"

#include "policy/policy_constants.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -24,7 +25,7 @@ namespace policy {

static const char kFakeONC[] = "{ \"GUID\": \"1234\" }";

static const char* kEmptyConfiguration =

- NetworkConfigurationUpdater::kEmptyConfiguration;

+ chromeos::onc::kEmptyUnencryptedConfiguration;

Joao da Silva 2012/12/13 09:51:35 Why not just remove kEmptyConfiguration and replac

pneubeck (no reviews) 2012/12/13 14:10:03 (Because it's longer.) Replaced.

class NetworkConfigurationUpdaterTest

: public testing::TestWithParam<const char*>{