Renderer process can allocate anonymous shared memory without help from browser process on Windows.

Renderer process can allocate anonymous shared memory without help from browser process on Windows.

The browser process IO thread can be busy at startup time. This saves about 20ms to allocate the first command buffer.

Refactored so PepperPluginDelegateImpl and PrintWebViewHelper use the same function to allocate shared memory.

BUG=163215
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172748

[jamesr, 2012-12-06 22:31:12]

It looks like ui/surface/transport_dib_win.cc already has this opt

https://codereview.chromium.org/11469015/diff/1/content/renderer/render_threa...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/11469015/diff/1/content/renderer/render_threa...
content/renderer/render_thread_impl.cc:899: if
(!shared_memory->CreateAnonymous(size))
content/renderer/pepper/pepper_plugin_delegate_impl creates shared memory in the
same was as this #else. Can we abstract this function int something shared and
use it from both RenderThreadImpl and PepperPluginDelegateImpl?

[apatrick_chromium, 2012-12-07 01:43:07]

Refactored to reduce redundancy

+joi for content/public

[jamesr, 2012-12-07 01:52:36]

lgtm

[Jói, 2012-12-07 09:38:36]

LGTM for content/public.

[commit-bot: I haz the power, 2012-12-11 23:59:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apatrick@chromium.org/11469015/15001

[commit-bot: I haz the power, 2012-12-11 23:59:41]

Presubmit check for 11469015-15001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 1.2s to calculate.

[apatrick_chromium, 2012-12-12 00:30:18]

Oops. Misread chrome/renderer as content/renderer. +thestig for chrome owners.

[Lei Zhang, 2012-12-12 00:37:40]

chrome/renderer lgtm

[commit-bot: I haz the power, 2012-12-12 00:49:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apatrick@chromium.org/11469015/15001

[commit-bot: I haz the power, 2012-12-12 02:22:19]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-12-12 02:48:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apatrick@chromium.org/11469015/41001

[commit-bot: I haz the power, 2012-12-12 02:57:22]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-12-12 19:31:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apatrick@chromium.org/11469015/37006

[commit-bot: I haz the power, 2012-12-12 21:41:10]

Retried try job too often on linux_chromeos for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-12 21:59:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apatrick@chromium.org/11469015/37006