Issue 11469014: Add a safe API for creating ASCII-only strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11469014: Add a safe API for creating ASCII-only strings

Created:
8 years ago by piscisaureus

Modified:
8 years ago

Reviewers:
piscisaureus, bnoordhuis1

CC:
v8-dev

Visibility:
Public.

Description

Add a safe API for creating ASCII-only strings

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -0 lines)			Patch
M	include/v8.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/factory.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/factory.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+22 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bnoordhuis1

https://codereview.chromium.org/11469014/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/11469014/diff/1/src/heap.cc#newcode4552 src/heap.cc:4552: string_result->SeqAsciiStringSet(i, AllocateRawAsciiString and SeqAsciiString don't exist in HEAD.

8 years ago (2012-12-07 04:54:47 UTC) #1

drcarney

This patch conflicts with an upcoming api change I will be making to allow the ...

8 years ago (2012-12-10 10:37:14 UTC) #2

drcarney

8 years ago (2012-12-10 10:39:21 UTC) #3

additionally, i plan to have a flag to mark the string as ascii only in this new
api call.

Expand Messages | Collapse Messages