Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: Source/core/html/shadow/PickerIndicatorElement.cpp

Issue 1146893005: Cleanup: Remove unnecessary code related to PagePopupDriver. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/shadow/PickerIndicatorElement.h ('k') | Source/core/page/ChromeClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/shadow/PickerIndicatorElement.cpp
diff --git a/Source/core/html/shadow/PickerIndicatorElement.cpp b/Source/core/html/shadow/PickerIndicatorElement.cpp
index 7884fab922a8c9f639b88491842cf5881af01599..f4d51d1376409a500fd512743460825c05c3ac6f 100644
--- a/Source/core/html/shadow/PickerIndicatorElement.cpp
+++ b/Source/core/html/shadow/PickerIndicatorElement.cpp
@@ -40,7 +40,6 @@
#include "core/page/ChromeClient.h"
#include "core/page/Page.h"
#include "platform/LayoutTestSupport.h"
-#include "wtf/TemporaryChange.h"
using namespace WTF::Unicode;
@@ -51,7 +50,6 @@ using namespace HTMLNames;
inline PickerIndicatorElement::PickerIndicatorElement(Document& document, PickerIndicatorOwner& pickerIndicatorOwner)
: HTMLDivElement(document)
, m_pickerIndicatorOwner(&pickerIndicatorOwner)
- , m_isInOpenPopup(false)
{
}
@@ -124,12 +122,6 @@ void PickerIndicatorElement::didEndChooser()
void PickerIndicatorElement::openPopup()
{
- // The m_isInOpenPopup flag is unnecessary in production.
- // MockPagePopupDriver allows to execute JavaScript code in
- // DateTimeChooserImpl constructor. It might create another DateTimeChooser.
- if (m_isInOpenPopup)
- return;
- TemporaryChange<bool> reentrancyProtector(m_isInOpenPopup, true);
if (m_chooser)
return;
if (!document().page())
« no previous file with comments | « Source/core/html/shadow/PickerIndicatorElement.h ('k') | Source/core/page/ChromeClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698