[MacViews] Enable dragging a window by its caption/draggable areas.

ui/base/test/windowed_nsnotification_observer.mm

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ui/base/test/windowed_nsnotification_observer.h"
+
+#import "base/mac/sdk_forward_declarations.h"

[tapted, 2015/06/03 07:04:49]

is this needed?

[jackhou1, 2015/06/03 08:13:51]

Done.

+
+@interface WindowedNSNotificationObserver ()
+- (void)observe:(NSNotification*)notification;

[tapted, 2015/06/03 07:04:49]

maybe observe -> onNotificationMessage? or onNotification? or
notificationReceived?

(observe sounds too much like it's doing "AddObserver"

[jackhou1, 2015/06/03 08:13:51]

Done.

+@end
+
+@implementation WindowedNSNotificationObserver
+
+- (id)initForNotification:(NSString*)name {
+  if (self = [super init]) {

[tapted, 2015/06/03 07:04:49]

double brackets around assignment in an `if` .. usually there's a warning for
this :/

[jackhou1, 2015/06/03 08:13:51]

Done.

+    [[NSNotificationCenter defaultCenter] addObserver:self
+                                             selector:@selector(observe:)
+                                                 name:name
+                                               object:nil];
+  }
+  return self;
+}
+
+- (id)initForNotification:(NSString*)name
+              andBundleId:(NSString*)bundleId {
+  if (self = [super init]) {

[tapted, 2015/06/03 07:04:49]

if ((self = ..

[jackhou1, 2015/06/03 08:13:51]

Done.

+    bundleId_.reset([[bundleId copy] retain]);

[tapted, 2015/06/03 07:04:49]

I don't think the retain is needed -- it's causing a refcount leak. (NSCopying
says "The returned object is implicitly retained by the sender")

[jackhou1, 2015/06/03 08:13:51]

Done.

+    [[[NSWorkspace sharedWorkspace] notificationCenter]
+        addObserver:self
+           selector:@selector(observe:)
+               name:name
+             object:nil];
+  }
+  return self;
+}
+
+- (void)observe:(NSNotification*)notification {
+  if (bundleId_) {
+    NSRunningApplication* application =
+        [[notification userInfo] objectForKey:NSWorkspaceApplicationKey];
+    if (![[application bundleIdentifier] isEqualToString:bundleId_])
+      return;
+
+    [[[NSWorkspace sharedWorkspace] notificationCenter] removeObserver:self];
+  } else {
+    [[NSNotificationCenter defaultCenter] removeObserver:self];
+  }
+
+  notificationReceived_ = YES;
+  if (runLoop_.get())
+    runLoop_->Quit();
+}
+
+- (void)wait {
+  if (notificationReceived_)
+    return;
+
+  runLoop_.reset(new base::RunLoop);

[tapted, 2015/06/03 07:04:49]

The run loop can go on the stack here. i.e. these lines become

base::RunLoop runLoop;
runLoop_ = &runLoop;
runLoop.Run();
runLoop_ = nullptr;

[jackhou1, 2015/06/03 08:13:51]

Done.

+  runLoop_->Run();
+}
+
+@end