Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7147)

Unified Diff: chrome/installer/util/shell_util.h

Issue 1146843003: Beacons for tracking default browser status. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gab comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/shell_util.h
diff --git a/chrome/installer/util/shell_util.h b/chrome/installer/util/shell_util.h
index 64e58482082f5bb02e5d327ae6408a0761003501..203e90d2ab14ac82cad03e822478fb71d2b9fa66 100644
--- a/chrome/installer/util/shell_util.h
+++ b/chrome/installer/util/shell_util.h
@@ -410,11 +410,12 @@ class ShellUtil {
// Windows prior to Windows 8.
static bool CanMakeChromeDefaultUnattended();
- // Returns the DefaultState of Chrome for HTTP and HTTPS.
+ // Returns the DefaultState of Chrome for HTTP and HTTPS, updating the default
gab 2015/06/01 18:43:12 s/, updating/and updates/ ? To me: "Foos bar, upd
grt (UTC plus 2) 2015/06/01 19:49:43 Done.
+ // browser beacons as appropriate.
static DefaultState GetChromeDefaultState();
- // Returns the DefaultState of the Chrome instance with the specified path
- // for HTTP and HTTPs.
+ // Returns the DefaultState of the Chrome instance with the specified path for
+ // HTTP and HTTPs, updating the default browser beacons as appropriate.
static DefaultState GetChromeDefaultStateFromPath(
const base::FilePath& chrome_exe);

Powered by Google App Engine
This is Rietveld 408576698