Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1146813013: Sky: Use the authenticated network service. (Closed)

Created:
5 years, 6 months ago by qsr
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M sky/sdk/lib/framework/net/fetch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/network.sky View 1 1 chunk +2 lines, -1 line 0 comments Download
M sky/viewer/content_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/viewer.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
qsr
5 years, 6 months ago (2015-06-08 20:15:35 UTC) #1
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-08 20:22:56 UTC) #2
qsr
5 years, 6 months ago (2015-06-09 07:46:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6fc7638b60f9b373f6b1a5ceb1ec4c7c95842e6c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698