Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1146813011: Move UnixDomainSocket to base namespace (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move UnixDomainSocket to base namespace Committed: https://crrev.com/a027ae3d51c7dc0e9974b301f31f5db95df37c70 Cr-Commit-Position: refs/heads/master@{#332446}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -95 lines) Patch
M base/posix/unix_domain_socket_linux.h View 6 chunks +10 lines, -8 lines 0 comments Download
M base/posix/unix_domain_socket_linux.cc View 9 chunks +14 lines, -10 lines 0 comments Download
M base/posix/unix_domain_socket_linux_unittest.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M components/nacl/loader/nacl_helper_linux.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M components/nacl/zygote/nacl_fork_delegate_linux.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M content/common/child_process_sandbox_support_impl_linux.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/common/child_process_sandbox_support_impl_shm_linux.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/common/font_config_ipc_linux.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M content/common/send_zygote_child_ping_linux.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/zygote/zygote_linux.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M sandbox/linux/integration_tests/namespace_unix_domain_socket_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M sandbox/linux/syscall_broker/broker_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/syscall_broker/broker_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sandbox/linux/syscall_broker/broker_process_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
brettw
5 years, 6 months ago (2015-06-02 16:28:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146813011/1
5 years, 6 months ago (2015-06-02 16:30:46 UTC) #4
sky
LGTM
5 years, 6 months ago (2015-06-02 17:02:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146813011/20001
5 years, 6 months ago (2015-06-02 17:32:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-02 19:48:39 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 19:49:31 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a027ae3d51c7dc0e9974b301f31f5db95df37c70
Cr-Commit-Position: refs/heads/master@{#332446}

Powered by Google App Engine
This is Rietveld 408576698