Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 1146813010: Introduce moderate binding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
index 9aaeba5b11cd02f1156806a2c62ce6eef24c16b4..b8371a28e945b82e751aa77a42048facd08aeada 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
@@ -18,6 +18,7 @@ import android.view.ViewGroup.LayoutParams;
import android.widget.FrameLayout;
import org.chromium.base.ActivityState;
+import org.chromium.base.ApplicationState;
import org.chromium.base.ApplicationStatus;
import org.chromium.base.CalledByNative;
import org.chromium.base.ObserverList;
@@ -112,6 +113,12 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
public static final int INVALID_TAB_ID = -1;
private static final long INVALID_TIMESTAMP = -1;
+ // TabRendererCrashStatus defined in tools/metrics/histograms/histograms.xml.
+ private static final int TAB_RENDERER_CRASH_STATUS_SHOWN_IN_FOREGROUND_APP = 0;
+ private static final int TAB_RENDERER_CRASH_STATUS_HIDDEN_IN_FOREGROUND_APP = 1;
+ private static final int TAB_RENDERER_CRASH_STATUS_HIDDEN_IN_BACKGROUND_APP = 2;
+ private static final int TAB_RENDERER_CRASH_STATUS_MAX = 3;
+
/**
* The required page load percentage for the page to be considered ready assuming the
* TextureView is also ready.
@@ -565,6 +572,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
int activityState = ApplicationStatus.getStateForActivity(
mWindowAndroid.getActivity().get());
+ int rendererCrashStatus = TAB_RENDERER_CRASH_STATUS_MAX;
if (!processWasOomProtected
|| activityState == ActivityState.PAUSED
|| activityState == ActivityState.STOPPED
@@ -572,10 +580,21 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
// The tab crashed in background or was killed by the OS out-of-memory killer.
//setNeedsReload(true);
mNeedsReload = true;
+ if (ApplicationStatus.getStateForApplication()
+ == ApplicationState.HAS_RUNNING_ACTIVITIES) {
+ rendererCrashStatus = TAB_RENDERER_CRASH_STATUS_HIDDEN_IN_FOREGROUND_APP;
+ } else {
+ rendererCrashStatus = TAB_RENDERER_CRASH_STATUS_HIDDEN_IN_BACKGROUND_APP;
+ }
} else {
+ rendererCrashStatus = TAB_RENDERER_CRASH_STATUS_SHOWN_IN_FOREGROUND_APP;
showSadTab();
+ // TODO(jaekyun): This isn't needed anymore because a histogram
+ // "Tab.RendererCrashStatus" is recorded.
UmaSessionStats.logRendererCrash(mWindowAndroid.getActivity().get());
}
+ RecordHistogram.recordEnumeratedHistogram(
+ "Tab.RendererCrashStatus", rendererCrashStatus, TAB_RENDERER_CRASH_STATUS_MAX);
mIsLoading = false;
mIsBeingRestored = false;
« no previous file with comments | « no previous file | chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698