Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 1146813010: Introduce moderate binding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve Yaron's comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
index dbff0bed6d3950e2bb4465a0aea3628f587f9725..3b5af1e95b78604a02217cd328a5433cd5799d80 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
@@ -18,6 +18,7 @@ import android.view.ViewGroup.LayoutParams;
import android.widget.FrameLayout;
import org.chromium.base.ActivityState;
+import org.chromium.base.ApplicationState;
import org.chromium.base.ApplicationStatus;
import org.chromium.base.CalledByNative;
import org.chromium.base.ObserverList;
@@ -25,6 +26,7 @@ import org.chromium.base.ObserverList.RewindableIterator;
import org.chromium.base.TraceEvent;
import org.chromium.base.VisibleForTesting;
import org.chromium.base.metrics.RecordHistogram;
+import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.TabState.WebContentsState;
import org.chromium.chrome.browser.TabUma.TabCreationState;
@@ -565,6 +567,10 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
// The tab crashed in background or was killed by the OS out-of-memory killer.
//setNeedsReload(true);
mNeedsReload = true;
+ if (ApplicationStatus.getStateForApplication()
+ == ApplicationState.HAS_RUNNING_ACTIVITIES) {
+ RecordUserAction.record("MobileBackgroundRendererCrashedOnForegroundApp");
+ }
} else {
showSadTab();
UmaSessionStats.logRendererCrash(mWindowAndroid.getActivity().get());

Powered by Google App Engine
This is Rietveld 408576698