Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1146813003: Remove mojo::InterfaceImpl from render_thread_impl and web_ui_mojo_browsertest. (Closed)

Created:
5 years, 7 months ago by Sam McNally
Modified:
5 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove mojo::InterfaceImpl from render_thread_impl and web_ui_mojo_browsertest. BUG=489751 Committed: https://crrev.com/f3670439cff020a55a70c8df8571dd5c061842e6 Cr-Commit-Position: refs/heads/master@{#330838}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M content/browser/webui/web_ui_mojo_browsertest.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sam McNally
5 years, 7 months ago (2015-05-20 04:39:07 UTC) #3
jam
lgtm
5 years, 7 months ago (2015-05-20 15:05:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146813003/20001
5 years, 7 months ago (2015-05-20 23:21:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-20 23:31:51 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 23:33:29 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f3670439cff020a55a70c8df8571dd5c061842e6
Cr-Commit-Position: refs/heads/master@{#330838}

Powered by Google App Engine
This is Rietveld 408576698