Vanquish the remnants of media::MessageLoopFactory.

chrome/renderer/chrome_content_renderer_client.h

Index: chrome/renderer/chrome_content_renderer_client.h
diff --git a/chrome/renderer/chrome_content_renderer_client.h b/chrome/renderer/chrome_content_renderer_client.h
index 339e2867a047b690a7a33ba5cf4a433d0b1b13f7..0d083418124304995be795a4d29fa41616d43adc 100644
--- a/chrome/renderer/chrome_content_renderer_client.h
+++ b/chrome/renderer/chrome_content_renderer_client.h
@@ -80,10 +80,9 @@ class ChromeContentRendererClient : public content::ContentRendererClient {
       WebKit::WebFrame* frame,
       WebKit::WebMediaPlayerClient* client,
       base::WeakPtr<webkit_media::WebMediaPlayerDelegate> delegate,
-      media::FilterCollection* collection,
       WebKit::WebAudioSourceProvider* audio_source_provider,
       media::AudioRendererSink* audio_renderer_sink,
-      media::MessageLoopFactory* message_loop_factory,
+      const scoped_refptr<media::GpuVideoDecoder::Factories>& gpu_factories,

[scherkus (not reviewing), 2012/12/07 23:54:11]

we can't forward declare the inner class, resulting in an entry to
content/public/renderer/DEPS

jam: any ideas? de-inner-ify the class? switch to a params struct similar to
OverrideCreatePlugin()? (I hate the amount of param plumbing going on here)

[jam, 2012/12/10 04:23:03]

this is why the style guide says to avoid nested classes, since they can't be
forward declared:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Nested_Classes

it seems good to minimize the includes of content_*_client.h files by forward
declaring parameters

       webkit_media::MediaStreamClient* media_stream_client,
       media::MediaLog* media_log) OVERRIDE;
   virtual bool RunIdleHandlerWhenWidgetsHidden() OVERRIDE;