Vanquish the remnants of media::MessageLoopFactory.

chrome/renderer/chrome_content_renderer_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_CHROME_CONTENT_RENDERER_CLIENT_H_
 #define CHROME_RENDERER_CHROME_CONTENT_RENDERER_CLIENT_H_
 
 #include <set>
 #include <string>
 
@@ skipping 62 matching lines @@
   virtual void GetNavigationErrorStrings(
       const WebKit::WebURLRequest& failed_request,
       const WebKit::WebURLError& error,
       std::string* error_html,
       string16* error_description) OVERRIDE;
   virtual webkit_media::WebMediaPlayerImpl* OverrideCreateWebMediaPlayer(
       content::RenderView* render_view,
       WebKit::WebFrame* frame,
       WebKit::WebMediaPlayerClient* client,
       base::WeakPtr<webkit_media::WebMediaPlayerDelegate> delegate,
-      media::FilterCollection* collection,
       WebKit::WebAudioSourceProvider* audio_source_provider,
       media::AudioRendererSink* audio_renderer_sink,
-      media::MessageLoopFactory* message_loop_factory,
+      const scoped_refptr<media::GpuVideoDecoder::Factories>& gpu_factories,

[scherkus (not reviewing), 2012/12/07 23:54:11]

we can't forward declare the inner class, resulting in an entry to
content/public/renderer/DEPS

jam: any ideas? de-inner-ify the class? switch to a params struct similar to
OverrideCreatePlugin()? (I hate the amount of param plumbing going on here)

[jam, 2012/12/10 04:23:03]

this is why the style guide says to avoid nested classes, since they can't be
forward declared:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Nested_Classes

it seems good to minimize the includes of content_*_client.h files by forward
declaring parameters

       webkit_media::MediaStreamClient* media_stream_client,
       media::MediaLog* media_log) OVERRIDE;
   virtual bool RunIdleHandlerWhenWidgetsHidden() OVERRIDE;
   virtual bool AllowPopup() OVERRIDE;
   virtual bool ShouldFork(WebKit::WebFrame* frame,
                           const GURL& url,
                           bool is_initial_navigation,
                           bool* send_referrer) OVERRIDE;
   virtual bool WillSendRequest(WebKit::WebFrame* frame,
                                content::PageTransition transition_type,
@@ skipping 80 matching lines @@
   scoped_ptr<RendererNetPredictor> net_predictor_;
   scoped_ptr<SpellCheck> spellcheck_;
   scoped_ptr<VisitedLinkSlave> visited_link_slave_;
   scoped_ptr<safe_browsing::PhishingClassifierFilter> phishing_classifier_;
   scoped_ptr<prerender::PrerenderDispatcher> prerender_dispatcher_;
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_RENDERER_CHROME_CONTENT_RENDERER_CLIENT_H_