Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: runtime/lib/string.cc

Issue 11468016: Rename GET_NATIVE_ARGUMENT macro to GET_NON_NULL_NATIVE_ARGUMENT. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/lib/regexp.cc ('k') | runtime/lib/weak_property.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/bootstrap_natives.h" 5 #include "vm/bootstrap_natives.h"
6 6
7 #include "vm/exceptions.h" 7 #include "vm/exceptions.h"
8 #include "vm/native_entry.h" 8 #include "vm/native_entry.h"
9 #include "vm/object.h" 9 #include "vm/object.h"
10 #include "vm/symbols.h" 10 #include "vm/symbols.h"
11 #include "vm/unicode.h" 11 #include "vm/unicode.h"
12 12
13 namespace dart { 13 namespace dart {
14 14
15 DEFINE_NATIVE_ENTRY(StringBase_createFromCodePoints, 1) { 15 DEFINE_NATIVE_ENTRY(StringBase_createFromCodePoints, 1) {
16 GET_NATIVE_ARGUMENT(Array, a, arguments->NativeArgAt(0)); 16 GET_NON_NULL_NATIVE_ARGUMENT(Array, a, arguments->NativeArgAt(0));
17 // TODO(srdjan): Check that parameterized type is an int. 17 // TODO(srdjan): Check that parameterized type is an int.
18 Zone* zone = isolate->current_zone(); 18 Zone* zone = isolate->current_zone();
19 intptr_t array_len = a.Length(); 19 intptr_t array_len = a.Length();
20 20
21 // Unbox the array and determine the maximum element width. 21 // Unbox the array and determine the maximum element width.
22 bool is_one_byte_string = true; 22 bool is_one_byte_string = true;
23 intptr_t utf16_len = array_len; 23 intptr_t utf16_len = array_len;
24 int32_t* utf32_array = zone->Alloc<int32_t>(array_len); 24 int32_t* utf32_array = zone->Alloc<int32_t>(array_len);
25 Object& index_object = Object::Handle(isolate); 25 Object& index_object = Object::Handle(isolate);
26 for (intptr_t i = 0; i < array_len; i++) { 26 for (intptr_t i = 0; i < array_len; i++) {
(...skipping 19 matching lines...) Expand all
46 } 46 }
47 if (is_one_byte_string) { 47 if (is_one_byte_string) {
48 return OneByteString::New(utf32_array, array_len, Heap::kNew); 48 return OneByteString::New(utf32_array, array_len, Heap::kNew);
49 } 49 }
50 return TwoByteString::New(utf16_len, utf32_array, array_len, Heap::kNew); 50 return TwoByteString::New(utf16_len, utf32_array, array_len, Heap::kNew);
51 } 51 }
52 52
53 53
54 DEFINE_NATIVE_ENTRY(StringBase_substringUnchecked, 3) { 54 DEFINE_NATIVE_ENTRY(StringBase_substringUnchecked, 3) {
55 const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0)); 55 const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0));
56 GET_NATIVE_ARGUMENT(Smi, start_obj, arguments->NativeArgAt(1)); 56 GET_NON_NULL_NATIVE_ARGUMENT(Smi, start_obj, arguments->NativeArgAt(1));
57 GET_NATIVE_ARGUMENT(Smi, end_obj, arguments->NativeArgAt(2)); 57 GET_NON_NULL_NATIVE_ARGUMENT(Smi, end_obj, arguments->NativeArgAt(2));
58 58
59 intptr_t start = start_obj.Value(); 59 intptr_t start = start_obj.Value();
60 intptr_t end = end_obj.Value(); 60 intptr_t end = end_obj.Value();
61 return String::SubString(receiver, start, (end - start)); 61 return String::SubString(receiver, start, (end - start));
62 } 62 }
63 63
64 64
65 DEFINE_NATIVE_ENTRY(OneByteString_substringUnchecked, 3) { 65 DEFINE_NATIVE_ENTRY(OneByteString_substringUnchecked, 3) {
66 const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0)); 66 const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0));
67 ASSERT(receiver.IsOneByteString()); 67 ASSERT(receiver.IsOneByteString());
68 GET_NATIVE_ARGUMENT(Smi, start_obj, arguments->NativeArgAt(1)); 68 GET_NON_NULL_NATIVE_ARGUMENT(Smi, start_obj, arguments->NativeArgAt(1));
69 GET_NATIVE_ARGUMENT(Smi, end_obj, arguments->NativeArgAt(2)); 69 GET_NON_NULL_NATIVE_ARGUMENT(Smi, end_obj, arguments->NativeArgAt(2));
70 70
71 const intptr_t start = start_obj.Value(); 71 const intptr_t start = start_obj.Value();
72 const intptr_t end = end_obj.Value(); 72 const intptr_t end = end_obj.Value();
73 return OneByteString::New(receiver, start, end - start, Heap::kNew); 73 return OneByteString::New(receiver, start, end - start, Heap::kNew);
74 } 74 }
75 75
76 76
77 // This is high-performance code. 77 // This is high-performance code.
78 DEFINE_NATIVE_ENTRY(OneByteString_splitWithCharCode, 2) { 78 DEFINE_NATIVE_ENTRY(OneByteString_splitWithCharCode, 2) {
79 const String& receiver = String::CheckedHandle(isolate, 79 const String& receiver = String::CheckedHandle(isolate,
80 arguments->NativeArgAt(0)); 80 arguments->NativeArgAt(0));
81 ASSERT(receiver.IsOneByteString()); 81 ASSERT(receiver.IsOneByteString());
82 GET_NATIVE_ARGUMENT(Smi, smi_split_code, arguments->NativeArgAt(1)); 82 GET_NON_NULL_NATIVE_ARGUMENT(Smi, smi_split_code, arguments->NativeArgAt(1));
83 const intptr_t len = receiver.Length(); 83 const intptr_t len = receiver.Length();
84 const intptr_t split_code = smi_split_code.Value(); 84 const intptr_t split_code = smi_split_code.Value();
85 const GrowableObjectArray& result = GrowableObjectArray::Handle( 85 const GrowableObjectArray& result = GrowableObjectArray::Handle(
86 isolate, 86 isolate,
87 GrowableObjectArray::New(16, Heap::kNew)); 87 GrowableObjectArray::New(16, Heap::kNew));
88 String& str = String::Handle(isolate); 88 String& str = String::Handle(isolate);
89 intptr_t start = 0; 89 intptr_t start = 0;
90 intptr_t i = 0; 90 intptr_t i = 0;
91 for (; i < len; i++) { 91 for (; i < len; i++) {
92 if (split_code == OneByteString::CharAt(receiver, i)) { 92 if (split_code == OneByteString::CharAt(receiver, i)) {
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 GrowableArray<const Object*> arguments; 138 GrowableArray<const Object*> arguments;
139 arguments.Add(&index); 139 arguments.Add(&index);
140 Exceptions::ThrowByType(Exceptions::kRange, arguments); 140 Exceptions::ThrowByType(Exceptions::kRange, arguments);
141 return 0; 141 return 0;
142 } 142 }
143 } 143 }
144 144
145 145
146 DEFINE_NATIVE_ENTRY(String_charAt, 2) { 146 DEFINE_NATIVE_ENTRY(String_charAt, 2) {
147 const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0)); 147 const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0));
148 GET_NATIVE_ARGUMENT(Integer, index, arguments->NativeArgAt(1)); 148 GET_NON_NULL_NATIVE_ARGUMENT(Integer, index, arguments->NativeArgAt(1));
149 uint32_t value = StringValueAt(receiver, index); 149 uint32_t value = StringValueAt(receiver, index);
150 ASSERT(value <= 0x10FFFF); 150 ASSERT(value <= 0x10FFFF);
151 return Symbols::FromCharCode(value); 151 return Symbols::FromCharCode(value);
152 } 152 }
153 153
154 DEFINE_NATIVE_ENTRY(String_charCodeAt, 2) { 154 DEFINE_NATIVE_ENTRY(String_charCodeAt, 2) {
155 const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0)); 155 const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0));
156 GET_NATIVE_ARGUMENT(Integer, index, arguments->NativeArgAt(1)); 156 GET_NON_NULL_NATIVE_ARGUMENT(Integer, index, arguments->NativeArgAt(1));
157 157
158 int32_t value = StringValueAt(receiver, index); 158 int32_t value = StringValueAt(receiver, index);
159 ASSERT(value >= 0); 159 ASSERT(value >= 0);
160 ASSERT(value <= 0x10FFFF); 160 ASSERT(value <= 0x10FFFF);
161 return Smi::New(value); 161 return Smi::New(value);
162 } 162 }
163 163
164 164
165 DEFINE_NATIVE_ENTRY(String_concat, 2) { 165 DEFINE_NATIVE_ENTRY(String_concat, 2) {
166 const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0)); 166 const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0));
167 GET_NATIVE_ARGUMENT(String, b, arguments->NativeArgAt(1)); 167 GET_NON_NULL_NATIVE_ARGUMENT(String, b, arguments->NativeArgAt(1));
168 return String::Concat(receiver, b); 168 return String::Concat(receiver, b);
169 } 169 }
170 170
171 171
172 DEFINE_NATIVE_ENTRY(String_toLowerCase, 1) { 172 DEFINE_NATIVE_ENTRY(String_toLowerCase, 1) {
173 const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0)); 173 const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0));
174 ASSERT(!receiver.IsNull()); 174 ASSERT(!receiver.IsNull());
175 return String::ToLowerCase(receiver); 175 return String::ToLowerCase(receiver);
176 } 176 }
177 177
178 178
179 DEFINE_NATIVE_ENTRY(String_toUpperCase, 1) { 179 DEFINE_NATIVE_ENTRY(String_toUpperCase, 1) {
180 const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0)); 180 const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0));
181 ASSERT(!receiver.IsNull()); 181 ASSERT(!receiver.IsNull());
182 return String::ToUpperCase(receiver); 182 return String::ToUpperCase(receiver);
183 } 183 }
184 184
185 185
186 DEFINE_NATIVE_ENTRY(Strings_concatAll, 1) { 186 DEFINE_NATIVE_ENTRY(Strings_concatAll, 1) {
187 GET_NATIVE_ARGUMENT(Array, strings, arguments->NativeArgAt(0)); 187 GET_NON_NULL_NATIVE_ARGUMENT(Array, strings, arguments->NativeArgAt(0));
188 ASSERT(!strings.IsNull()); 188 ASSERT(!strings.IsNull());
189 // Check that the array contains strings. 189 // Check that the array contains strings.
190 Instance& elem = Instance::Handle(); 190 Instance& elem = Instance::Handle();
191 for (intptr_t i = 0; i < strings.Length(); i++) { 191 for (intptr_t i = 0; i < strings.Length(); i++) {
192 elem ^= strings.At(i); 192 elem ^= strings.At(i);
193 if (!elem.IsString()) { 193 if (!elem.IsString()) {
194 GrowableArray<const Object*> args; 194 GrowableArray<const Object*> args;
195 args.Add(&elem); 195 args.Add(&elem);
196 Exceptions::ThrowByType(Exceptions::kArgument, args); 196 Exceptions::ThrowByType(Exceptions::kArgument, args);
197 } 197 }
198 } 198 }
199 return String::ConcatAll(strings); 199 return String::ConcatAll(strings);
200 } 200 }
201 201
202 } // namespace dart 202 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/lib/regexp.cc ('k') | runtime/lib/weak_property.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698