Rename GET_NATIVE_ARGUMENT macro to GET_NON_NULL_NATIVE_ARGUMENT.

runtime/vm/native_entry_test.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/native_entry_test.h"
 
 #include "vm/assembler.h"
 #include "vm/code_patcher.h"
+#include "vm/dart_api_impl.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 #include "vm/stack_frame.h"
 #include "vm/stub_code.h"
 #include "vm/unit_test.h"
 
 namespace dart {
 
 
 // A native call for test purposes.
@@ skipping 29 matching lines @@
     EXPECT_VALID(Dart_IntegerToInt64(arg, &arg_value));
 
     // Ignoring overflow in the addition below.
     result += arg_value;
   }
   Dart_SetReturnValue(args, Dart_NewInteger(result));
   Dart_ExitScope();
 }
 
 
+// Test for accepting null arguments in native function.
+// Arg0-4: 5 smis or null.
+// Result: a smi representing the sum of all non-null arguments.
+void TestNonNullSmiSum(Dart_NativeArguments args) {
+  Dart_EnterScope();
+  Isolate* isolate = Isolate::Current();
+  int64_t result = 0;
+  int arg_count = Dart_GetNativeArgumentCount(args);
+  // Test the lower level macro GET_NATIVE_ARGUMENT.
+  NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args);
+  for (int i = 0; i < arg_count; i++) {
+    Dart_Handle arg = Dart_GetNativeArgument(args, i);
+    GET_NATIVE_ARGUMENT(Integer, argument, arguments->NativeArgAt(i));

[siva, 2012/12/07 02:28:40]

EXPECT(argument.IsInteger());

Does that make sense?

[regis, 2012/12/10 17:58:42]

Done.

+    EXPECT_EQ(Api::UnwrapHandle(arg), argument.raw());  // May be null.
+    int64_t arg_value = -1;
+    if (argument.IsNull()) {
+      EXPECT_ERROR(Dart_IntegerToInt64(arg, &arg_value),
+                   "Dart_IntegerToInt64 expects argument 'integer' "
+                   "to be non-null.");
+    } else {
+      EXPECT_VALID(Dart_IntegerToInt64(arg, &arg_value));
+      EXPECT_EQ(arg_value, argument.AsInt64Value());
+      // Ignoring overflow in the addition below.
+      result += arg_value;
+    }
+  }
+  Dart_SetReturnValue(args, Dart_NewInteger(result));
+  Dart_ExitScope();
+}
+
+
 // Test code patching.
 void TestStaticCallPatching(Dart_NativeArguments args) {
   Dart_EnterScope();
   DartFrameIterator iterator;
   iterator.NextFrame();  // Skip native call.
   StackFrame* static_caller_frame = iterator.NextFrame();
   uword target_address =
       CodePatcher::GetStaticCallTargetAt(static_caller_frame->pc());
   const Code& code = Code::Handle(static_caller_frame->LookupDartCode());
   const Function& target_function =
       Function::Handle(code.GetStaticCallTargetFunctionAt(
           static_caller_frame->pc()));
   EXPECT(String::Handle(target_function.name()).
       Equals(String::Handle(String::New("NativePatchStaticCall"))));
   const uword function_entry_address =
       Code::Handle(target_function.CurrentCode()).EntryPoint();
   EXPECT_EQ(function_entry_address, target_address);
   Dart_ExitScope();
 }
 
 }  // namespace dart