Issue 11468: For some reason gcc didn't like a STATIC_ASSERT argument with '>' in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11468: For some reason gcc didn't like a STATIC_ASSERT argument with '>' in... (Closed)

Created:
12 years, 1 month ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

For some reason gcc didn't like a STATIC_ASSERT argument with '>' in it, because it confused parsing of the template that STATIC_ASSERT expands to. It's all too magical for me. Committed: http://code.google.com/p/v8/source/detail?r=789

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	src/checks.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	src/virtual-frame-ia32.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

12 years, 1 month ago (2008-11-19 09:28:31 UTC) #2

I can't say that I understand why one set of parenthesis is not enough, but if
it makes GCC happy it LGTM.

Expand Messages | Collapse Messages