src/lazy/SkDiscardablePixelRef.cpp - Issue 114673002: be sure to unlock the discardablememory before deleting it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lazy/SkDiscardablePixelRef.cpp

Issue 114673002: be sure to unlock the discardablememory before deleting it (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/lazy/SkDiscardablePixelRef.cpp

diff --git a/src/lazy/SkDiscardablePixelRef.cpp b/src/lazy/SkDiscardablePixelRef.cpp

index 6a9507c8c76a713bba3c7a85388e3f8e4c78d702..0b193ade3c35d234fa08b35aacf06e41bcfb4e89 100644

--- a/src/lazy/SkDiscardablePixelRef.cpp

+++ b/src/lazy/SkDiscardablePixelRef.cpp

@@ -30,6 +30,9 @@ SkDiscardablePixelRef::SkDiscardablePixelRef(SkImageGenerator* generator,

}

SkDiscardablePixelRef::~SkDiscardablePixelRef() {

+ if (this->isLocked()) {

+ fDiscardableMemory->unlock();

+ }

SkDELETE(fDiscardableMemory);

SkSafeUnref(fDMFactory);

SkDELETE(fGenerator);

« no previous file with comments | « src/lazy/SkDiscardableMemoryPool.cpp ('k') | tests/CachedDecodingPixelRefTest.cpp » ('j') | no next file with comments »