Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1146723002: New FRAME_DURATION VideoFrameMetadata, with Cast Streaming use case. (Closed)

Created:
5 years, 7 months ago by miu
Modified:
5 years, 7 months ago
Reviewers:
hubbe, DaleCurtis
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, avayvod+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

New FRAME_DURATION VideoFrameMetadata, with Cast Streaming use case. Adds a new FRAME_DURATION option to VideoFrameMetadata, which can be used by consumers of video frames to improve performance (e.g., encoding quality). This change also adds population of the new metadata by the desktop/tab capture pipeline, and consumption by Cast Streaming's software VP8 encoder. Having accurate frame duration information improves the encoder's ability to choose a compression quality level that better meets the target encode bitrate. Later changes will require this in order to compute resource utilization feedback signals (see bug for details). BUG=156767 Committed: https://crrev.com/1cb99158245ac2a36ea0ee5e20fd2fff71c864d1 Cr-Commit-Position: refs/heads/master@{#330661}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Expanded comments for VideoFrameMetadata::FRAME_DURATION. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -23 lines) Patch
M content/browser/media/capture/content_video_capture_device_core.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/media/capture/content_video_capture_device_core.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/media/capture/video_capture_oracle.h View 2 chunks +12 lines, -0 lines 0 comments Download
M content/browser/media/capture/video_capture_oracle.cc View 1 chunk +8 lines, -1 line 0 comments Download
M content/browser/media/capture/video_capture_oracle_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M media/base/video_frame_metadata.h View 1 3 chunks +14 lines, -1 line 0 comments Download
M media/base/video_frame_metadata.cc View 2 chunks +34 lines, -10 lines 0 comments Download
M media/base/video_frame_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M media/cast/sender/vp8_encoder.cc View 1 chunk +14 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
miu
hubbe: PTAL.
5 years, 7 months ago (2015-05-19 04:46:34 UTC) #3
hubbe
https://codereview.chromium.org/1146723002/diff/20001/media/base/video_frame_metadata.h File media/base/video_frame_metadata.h (right): https://codereview.chromium.org/1146723002/diff/20001/media/base/video_frame_metadata.h#newcode27 media/base/video_frame_metadata.h:27: FRAME_DURATION, I think some additional explanation is needed. I ...
5 years, 7 months ago (2015-05-19 17:58:32 UTC) #4
miu
https://codereview.chromium.org/1146723002/diff/20001/media/base/video_frame_metadata.h File media/base/video_frame_metadata.h (right): https://codereview.chromium.org/1146723002/diff/20001/media/base/video_frame_metadata.h#newcode27 media/base/video_frame_metadata.h:27: FRAME_DURATION, On 2015/05/19 17:58:32, hubbe wrote: > I think ...
5 years, 7 months ago (2015-05-19 20:14:52 UTC) #5
hubbe
lgtm
5 years, 7 months ago (2015-05-19 20:28:51 UTC) #6
miu
dalecurtis: PTAL for media/ OWNERS approval.
5 years, 7 months ago (2015-05-19 20:40:54 UTC) #8
DaleCurtis
lgtm
5 years, 7 months ago (2015-05-19 23:31:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146723002/40001
5 years, 7 months ago (2015-05-20 00:22:14 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-05-20 00:31:43 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 00:32:33 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1cb99158245ac2a36ea0ee5e20fd2fff71c864d1
Cr-Commit-Position: refs/heads/master@{#330661}

Powered by Google App Engine
This is Rietveld 408576698