Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: runtime/embedders/android/android_extension.cc

Issue 11467028: Migrate files to embedder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review fixes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/embedders/android/android_extension.h ('k') | runtime/embedders/android/context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/embedders/android/android_extension.cc
diff --git a/samples/android_sample/jni/android_extension.cc b/runtime/embedders/android/android_extension.cc
similarity index 99%
rename from samples/android_sample/jni/android_extension.cc
rename to runtime/embedders/android/android_extension.cc
index 27c4c05f82add4f018fa9ded5ff7e0bac2fdd96e..8dcedb3c515aadab92411b32c52ddace0ef26d38 100644
--- a/samples/android_sample/jni/android_extension.cc
+++ b/runtime/embedders/android/android_extension.cc
@@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-#include "jni/android_extension.h"
+#include "embedders/android/android_extension.h"
#include <android/log.h>
#include <EGL/egl.h>
@@ -14,7 +14,7 @@
#include <string.h>
#include "include/dart_api.h"
-#include "jni/log.h"
+#include "embedders/android/log.h"
Dart_Handle HandleError(Dart_Handle handle) {
if (Dart_IsError(handle)) Dart_PropagateError(handle);
@@ -863,7 +863,11 @@ void GLViewport(Dart_NativeArguments arguments) {
int64_t height;
HandleError(Dart_IntegerToInt64(heightHandle, &height));
- LOGI("Dimensions: [%ld, %ld, %ld, %ld]", x, y, width, height);
+ LOGI("Dimensions: [%d, %d, %d, %d]",
+ static_cast<int>(x),
+ static_cast<int>(y),
+ static_cast<int>(width),
+ static_cast<int>(height));
glViewport(x, y, width, height);
CheckGLError("glViewPort");
« no previous file with comments | « runtime/embedders/android/android_extension.h ('k') | runtime/embedders/android/context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698