Issue 11467021: Make sure HMathMinMax always has a supported representation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11467021: Make sure HMathMinMax always has a supported representation (Closed)

Created:
8 years ago by Jakob Kummerow

Modified:
8 years ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make sure HMathMinMax always has a supported representation Committed: http://code.google.com/p/v8/source/detail?r=13180

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	src/hydrogen-instructions.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/hydrogen-instructions.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Please take a look. This fixes http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%203/builds/9/steps/Check/logs/stdio . HMathMinMax only supports Integer32 or Double representation. ...

8 years ago (2012-12-07 16:41:40 UTC) #1

Michael Starzinger

LGTM. Do we have an easy repro for that, which could serve as a regression ...

8 years ago (2012-12-10 11:38:22 UTC) #2

Jakob Kummerow

8 years ago (2012-12-10 11:54:34 UTC) #3

Thanks, landing.

I don't have a reduced repro beyond the GC stress bot test, and as discussed
offline we won't spend the time to create one now.

Expand Messages | Collapse Messages