Issue 11467013: First cut at UI for saving net_internals data into a file for mobile (Android and Ios).

Issue 11467013: First cut at UI for saving net_internals data into a file for mobile (Android and Ios). (Closed)

Created:
8 years ago by ramant (doing other things)

Modified:
8 years ago

Reviewers:
droger, qsr

CC:
chromium-reviews, arv (Not doing code reviews), mmenke, eroman

Base URL:
https://src.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

First cut at UI for saving net_internals data into a file for mobile (Android and Ios). R=droger@chromium.org BUG=151212 Created the following new CL (migrated to a new machine). https://chromiumcodereview.appspot.com/11635023/ Will publish that CL asap.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+343 lines, -8 lines)			Patch
M	chrome/browser/net/net_log_logger.h	View	1 2	2 chunks	+22 lines, -0 lines	3 comments	Download
M	chrome/browser/net/net_log_logger.cc	View	1 2	2 chunks	+137 lines, -5 lines	1 comment	Download
M	chrome/browser/resources/net_internals/browser_bridge.js	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/net_internals/category_tabs.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/net_internals/index.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/net_internals/index.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/net_internals/main.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/net_internals/mobile_view.html	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/net_internals/mobile_view.js	View		1 chunk	+74 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/shared/js/cr.js	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/net_internals/net_internals_ui.cc	View	1 2	4 chunks	+34 lines, -0 lines	0 comments	Download
M	chrome/test/data/webui/net_internals/log_util.js	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/data/webui/net_internals/main.js	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/data/webui/net_internals/net_internals_test.js	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

Added a tab for Mobile (Android and Ios) to start/Send/Stop net_internals data.

8 years ago (2012-12-07 05:56:04 UTC) #1

ramant (doing other things)

On 2012/12/07 05:56:04, ramant wrote: > Added a tab for Mobile (Android and Ios) to ...

8 years ago (2012-12-07 22:52:47 UTC) #2

ramant (doing other things)

On 2012/12/07 22:52:47, ramant wrote: > On 2012/12/07 05:56:04, ramant wrote: > > Added a ...

8 years ago (2012-12-10 06:21:52 UTC) #3

droger

+qsr I'm not really famliar with the web UI code, adding qsr who might know ...

8 years ago (2012-12-10 10:37:07 UTC) #4

qsr

8 years ago (2012-12-10 10:51:07 UTC) #5

https://chromiumcodereview.appspot.com/11467013/diff/12/chrome/browser/net/ne...
File chrome/browser/net/net_log_logger.h (right):

https://chromiumcodereview.appspot.com/11467013/diff/12/chrome/browser/net/ne...
chrome/browser/net/net_log_logger.h:44: static void StartNetLog();
Did you see with any of the Owners if that is fine with them... I don't really
see why you are doing this. Can you use a  NetLogLogger as it is with a given
file path where you need it, instead of having all those static methods?

https://chromiumcodereview.appspot.com/11467013/diff/12/chrome/browser/net/ne...
chrome/browser/net/net_log_logger.h:57: static void SendEmail(const
FilePath::StringType& file_to_attch);
1. attach
2. Why isn't this a const FilePath& ?

https://chromiumcodereview.appspot.com/11467013/diff/12/chrome/browser/net/ne...
chrome/browser/net/net_log_logger.h:61: std::vector<FilePath::StringType>
files_to_delete_;
Same thing here, why isn't those FilePath?

Expand Messages | Collapse Messages