Enable client certificates in SecureSocket and SecureServerSocket

runtime/bin/secure_socket.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef BIN_SECURE_SOCKET_H_
 #define BIN_SECURE_SOCKET_H_
 
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
@@ skipping 56 matching lines @@
         string_length_(NULL),
         handshake_complete_(NULL),
         bad_certificate_callback_(NULL),
         in_handshake_(false),
         filter_(NULL) { }
 
   void Init(Dart_Handle dart_this);
   void Connect(const char* host,
                int port,
                bool is_server,
-               const char* certificate_name);
+               const char* certificate_name,

[Søren Gjesse, 2012/12/07 13:00:23]

Now about making an int with flags here instead of a number of boolean
arguments. is_server could be a flag as well.

[Bill Hesse, 2012/12/10 15:15:48]

Because we would just pack them all up before calling the function, and unpack
them all in the called function, using flag definitions on the bits that need to
be added to the Dart and C++ files, and kept in sync between them, I think it is
clearer, and not that much less efficient, to just pass them explicitly.  We can
always change this later, especially if we add more flags.

+               bool request_client_certificate,
+               bool require_client_certificate,
+               bool send_client_certificate);
   void Destroy();
   void Handshake();
   void RegisterHandshakeCompleteCallback(Dart_Handle handshake_complete);
   void RegisterBadCertificateCallback(Dart_Handle callback);
+  Dart_Handle bad_certificate_callback() { return bad_certificate_callback_; }
   static void InitializeLibrary(const char* certificate_database,
                                 const char* password,
                                 bool use_builtin_root_certificates);
-
   intptr_t ProcessBuffer(int bufferIndex);
-
-  SECStatus HandleBadCertificate(PRFileDesc* fd);
+  Dart_Handle PeerCertificate();
 
  private:
   static const int kMemioBufferSize = 20 * KB;
   static bool library_initialized_;
   static const char* password_;
   static dart::Mutex mutex_;  // To protect library initialization.
 
   uint8_t* buffers_[kNumBuffers];
   int64_t buffer_size_;
   Dart_Handle string_start_;
   Dart_Handle string_length_;
   Dart_Handle dart_buffer_objects_[kNumBuffers];
   Dart_Handle handshake_complete_;
   Dart_Handle bad_certificate_callback_;
   bool in_handshake_;
   bool is_server_;
   PRFileDesc* filter_;
 
   void InitializeBuffers(Dart_Handle dart_this);
   void InitializePlatformData();
 
   DISALLOW_COPY_AND_ASSIGN(SSLFilter);
 };
 
 #endif  // BIN_SECURE_SOCKET_H_