[Extensions] Move remaining notifications out of ExtensionSettingsHandler

chrome/browser/resources/extensions/extensions.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../../../../ui/webui/resources/js/cr/ui/focus_row.js">
 <include src="../../../../ui/webui/resources/js/cr/ui/focus_grid.js">
 <include src="../uber/uber_utils.js">
 <include src="extension_code.js">
 <include src="extension_commands_overlay.js">
 <include src="extension_error_overlay.js">
@@ skipping 130 matching lines @@
       measureCheckboxStrings();
 
       // Set the title.
       uber.setTitle(loadTimeData.getString('extensionSettings'));
 
       var extensionList = new ExtensionList(this);
       extensionList.id = 'extension-settings-list';
       var wrapper = $('extension-list-wrapper');
       wrapper.insertBefore(extensionList, wrapper.firstChild);
 
-      this.update_();
-      // TODO(devlin): Remove this once all notifications are moved to events on
-      // the developerPrivate api.
-      chrome.send('extensionSettingsRegister');
+      // Get the initial profile state, and register to be notified of any
+      // future changes.
+      chrome.developerPrivate.getProfileConfiguration(
+          this.update_.bind(this));
+      chrome.developerPrivate.onProfileStateChanged.addListener(
+          this.update_.bind(this));
 
       var extensionLoader = extensions.ExtensionLoader.getInstance();
 
       $('toggle-dev-on').addEventListener('change', function(e) {
         this.updateDevControlsVisibility_(true);
         extensionList.updateFocusableElements();
         chrome.developerPrivate.updateProfileConfiguration(
             {inDeveloperMode: e.target.checked});
         var suffix = $('toggle-dev-on').checked ? 'Enabled' : 'Disabled';
         chrome.send('metricsHandler:recordAction',
@@ skipping 68 matching lines @@
       var path = document.location.pathname;
       if (path.length > 1) {
         // Skip starting slash and remove trailing slash (if any).
         var overlayName = path.slice(1).replace(/\/$/, '');
         if (overlayName == 'configureCommands')
           this.showExtensionCommandsConfigUi_();
       }
     },
 
     /**
-     * Updates the extensions page to the latest profile and extensions
-     * configuration.
-     * @private
-     */
-    update_: function() {
-      chrome.developerPrivate.getProfileConfiguration(
-          this.returnProfileConfiguration_.bind(this));
-    },
-
-    /**
      * [Re]-Populates the page with data representing the current state of
      * installed extensions.
      * @param {ProfileInfo} profileInfo
      * @private
      */
-    returnProfileConfiguration_: function(profileInfo) {
+    update_: function(profileInfo) {
       webuiResponded = true;
+
       /** @const */
       var supervised = profileInfo.isSupervised;
 
       var pageDiv = $('extension-settings');
       pageDiv.classList.toggle('profile-is-supervised', supervised);
       pageDiv.classList.toggle('showing-banner', supervised);
 
       var devControlsCheckbox = $('toggle-dev-on');
       devControlsCheckbox.checked = profileInfo.inDeveloperMode;
       devControlsCheckbox.disabled = supervised;
@@ skipping 90 matching lines @@
     /** @override */
     onExtensionCountChanged: function() {
       /** @const */
       var hasExtensions = $('extension-settings-list').getNumExtensions() != 0;
       $('no-extensions').hidden = hasExtensions;
       $('extension-list-wrapper').hidden = !hasExtensions;
     },
   };
 
   /**
-   * Called by the WebUI when something has changed and the extensions UI needs
-   * to be updated.
-   */
-  ExtensionSettings.onExtensionsChanged = function() {
-    ExtensionSettings.getInstance().update_();
-  };
-
-  /**
    * Returns the current overlay or null if one does not exist.
    * @return {Element} The overlay element.
    */
   ExtensionSettings.getCurrentOverlay = function() {
     return document.querySelector('#overlay .page.showing');
   };
 
   /**
    * Sets the given overlay to show. If the overlay is already showing, this is
    * a no-op; otherwise, hides any currently-showing overlay.
@@ skipping 91 matching lines @@
   // Export
   return {
     ExtensionSettings: ExtensionSettings
   };
 });
 
 window.addEventListener('load', function(e) {
   document.documentElement.classList.add('loading');
   extensions.ExtensionSettings.getInstance().initialize();
 });