[destructuring] Implement initializers in patterns.

test/cctest/test-parsing.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 6345 matching lines @@
 TEST(DestructuringPositiveTests) {
   i::FLAG_harmony_destructuring = true;
 
   const char* context_data[][2] = {{"'use strict'; let ", " = {};"},
                                    {"var ", " = {};"},
                                    {"'use strict'; const ", " = {};"},
                                    {NULL, NULL}};
 
   // clang-format off
   const char* data[] = {
+    "x",

[arv (Not doing code reviews), 2015/05/18 14:36:20]

this is a duplicate of the next line

[Dmitry Lomov (no reviews), 2015/05/18 17:31:23]

Done.

     "a",
     "{ x : y }",
+    "{ x : y = 1 }",
     "[a]",
+    "[a = 1]",
     "[a,b,c]",
+    "[a, b = 42, c]",
     "{ x : x, y : y }",
+    "{ x : x = 1, y : y }",
+    "{ x : x, y : y = 42 }",
     "[]",
     "{}",
     "[{x:x, y:y}, [a,b,c]]",
+    "[{x:x = 1, y:y = 2}, [a = 3, b = 4, c = 5]]",
+    "{x}",
+    "{x, y}",
+    "{x = 42, y = 15}",
     "[a,,b]",
     "{42 : x}",
+    "{42 : x = 42}",
     "{42e-2 : x}",
+    "{42e-2 : x = 42}",
     "{'hi' : x}",
+    "{'hi' : x = 42}",
     "{var: x}",
+    "{var: x = 42}",

[rossberg, 2015/05/18 16:17:19]

Add a test with computed property names.

[Dmitry Lomov (no reviews), 2015/05/18 17:31:22]

I want to cover computed property names in a separate CL; this CL is about
intializers.

     "{}",
     NULL};
   // clang-format on
-  static const ParserFlag always_flags[] = {kAllowHarmonyDestructuring};
+  static const ParserFlag always_flags[] = {kAllowHarmonyObjectLiterals,
+                                            kAllowHarmonyDestructuring};
   RunParserSyncTest(context_data, data, kSuccess, NULL, 0, always_flags,
                     arraysize(always_flags));
 }
 
 
 TEST(DestructuringNegativeTests) {
   i::FLAG_harmony_destructuring = true;
-  static const ParserFlag always_flags[] = {kAllowHarmonyDestructuring};
+  static const ParserFlag always_flags[] = {kAllowHarmonyObjectLiterals,
+                                            kAllowHarmonyDestructuring};
 
   {  // All modes.
     const char* context_data[][2] = {{"'use strict'; let ", " = {};"},
                                      {"var ", " = {};"},
                                      {"'use strict'; const ", " = {};"},
                                      {NULL, NULL}};
 
     // clang-format off
     const char* data[] = {
         "a++",
@@ skipping 31 matching lines @@
         "false",
         "1",
         "'abc'",
         "class {}",
         "() => x",
         "{+2 : x}",
         "{-2 : x}",
         "var",
         "[var]",
         "{x : {y : var}}",
+        "{x : x = a+}",
+        "{x : x = (a+)}",
+        "{x : x += a}",

[rossberg, 2015/05/18 16:17:19]

Add a test with method syntax, e.g. "{m() {} = 0}".

[Dmitry Lomov (no reviews), 2015/05/18 17:31:22]

Done.

         NULL};
     // clang-format on
     RunParserSyncTest(context_data, data, kError, NULL, 0, always_flags,
                       arraysize(always_flags));
   }
 
   {  // Strict mode.
     const char* context_data[][2] = {{"'use strict'; let ", " = {};"},
                                      {"'use strict'; const ", " = {};"},
                                      {NULL, NULL}};
@@ skipping 21 matching lines @@
     const char* data[] = {
       "yield",
       "[yield]",
       "{ x : yield }",
       NULL};
     // clang-format on
     RunParserSyncTest(context_data, data, kError, NULL, 0, always_flags,
                       arraysize(always_flags));
   }
 }