Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1146673002: [Cleanup] Inline strings constants used only once (Closed)

Created:
5 years, 7 months ago by sdefresne
Modified:
5 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@yandex
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Inline strings constants used only once BUG=None Committed: https://crrev.com/95fa136290ba37230f11a975d2646e498c872ccd Cr-Commit-Position: refs/heads/master@{#330544}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address pkasting comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -95 lines) Patch
M components/search_engines/template_url.cc View 1 6 chunks +40 lines, -95 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sdefresne
Please take a look. Note that this is dependent on https://codereview.chromium.org/1141743003/, so do not send ...
5 years, 7 months ago (2015-05-18 12:36:11 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/1146673002/diff/1/components/search_engines/template_url.cc File components/search_engines/template_url.cc (right): https://codereview.chromium.org/1146673002/diff/1/components/search_engines/template_url.cc#newcode65 components/search_engines/template_url.cc:65: // Used if the output encodeing parameter is ...
5 years, 7 months ago (2015-05-18 18:27:31 UTC) #2
sdefresne
Thank you for the review. https://codereview.chromium.org/1146673002/diff/1/components/search_engines/template_url.cc File components/search_engines/template_url.cc (right): https://codereview.chromium.org/1146673002/diff/1/components/search_engines/template_url.cc#newcode65 components/search_engines/template_url.cc:65: // Used if the ...
5 years, 7 months ago (2015-05-19 09:12:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146673002/20001
5 years, 7 months ago (2015-05-19 15:25:37 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 17:21:17 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 17:22:48 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95fa136290ba37230f11a975d2646e498c872ccd
Cr-Commit-Position: refs/heads/master@{#330544}

Powered by Google App Engine
This is Rietveld 408576698