Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1146563002: Revert "win: Make oilpan plugin work better with delayed template parsing." (Closed)

Created:
5 years, 7 months ago by brucedawson
Modified:
5 years, 7 months ago
Reviewers:
hans, Nico, Reid Kleckner
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "win: Make oilpan plugin work better with delayed template parsing." This reverts commit 28c1b1099fb09782841d891ca43e83e71cd8dfc6. The delayed_parsing.cpp file has no license which is causing license check failures. TBR=hans@chromium.org,thakis@chromium.org,rnk@chromium.org BUG=486571 Committed: https://crrev.com/09a5d794f0985c7ca36414d1907938e048946bcf Cr-Commit-Position: refs/heads/master@{#330289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -68 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 4 chunks +0 lines, -45 lines 0 comments Download
M tools/clang/blink_gc_plugin/Config.h View 2 chunks +2 lines, -2 lines 0 comments Download
D tools/clang/blink_gc_plugin/tests/delayed_parsing.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
D tools/clang/blink_gc_plugin/tests/delayed_parsing.flags View 1 chunk +0 lines, -1 line 0 comments Download
D tools/clang/blink_gc_plugin/tests/delayed_parsing.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146563002/1
5 years, 7 months ago (2015-05-16 15:55:17 UTC) #2
brucedawson
Committed patchset #1 (id:1) manually as 09a5d794f0985c7ca36414d1907938e048946bcf (presubmit successful).
5 years, 7 months ago (2015-05-16 16:01:21 UTC) #3
Nico
fyi, you can use the "Revert this patchset" button on a review on rietveld for ...
5 years, 7 months ago (2015-05-17 01:30:15 UTC) #4
Nico
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1135333007/ by thakis@chromium.org. ...
5 years, 7 months ago (2015-05-17 01:30:34 UTC) #5
brucedawson
I did actually try the revert button but it said it couldn't. I can't remember ...
5 years, 7 months ago (2015-05-17 06:50:28 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:31:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09a5d794f0985c7ca36414d1907938e048946bcf
Cr-Commit-Position: refs/heads/master@{#330289}

Powered by Google App Engine
This is Rietveld 408576698