Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: sync/tools/sync_client.cc

Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from Bartosz. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/invalidation/ticl_invalidation_service.cc ('k') | sync/tools/sync_listen_notifications.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/tools/sync_client.cc
diff --git a/sync/tools/sync_client.cc b/sync/tools/sync_client.cc
index 8422d2eb7ce4e62c06281d06b8a6e23585f1b572..c8aa9eabacf557dfe147ae7b036bd790755c32d1 100644
--- a/sync/tools/sync_client.cc
+++ b/sync/tools/sync_client.cc
@@ -445,8 +445,8 @@ int SyncClientMain(int argc, char* argv[]) {
invalidator->UpdateCredentials(credentials.email, credentials.sync_token);
scoped_ptr<InvalidatorShim> shim(new InvalidatorShim(sync_manager.get()));
invalidator->RegisterHandler(shim.get());
- invalidator->UpdateRegisteredIds(
- shim.get(), ModelTypeSetToObjectIdSet(model_types));
+ CHECK(invalidator->UpdateRegisteredIds(
+ shim.get(), ModelTypeSetToObjectIdSet(model_types)));
sync_manager->StartSyncingNormally(routing_info, base::Time());
sync_loop.Run();
« no previous file with comments | « components/invalidation/ticl_invalidation_service.cc ('k') | sync/tools/sync_listen_notifications.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698