components/invalidation/non_blocking_invalidator.h - Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/non_blocking_invalidator.h

Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from Bartosz. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/invalidation/non_blocking_invalidator.h

diff --git a/components/invalidation/non_blocking_invalidator.h b/components/invalidation/non_blocking_invalidator.h

index 0ca081af26fac9aaf45e94b4ca3910c6cd9a40d5..73db2802c1179652af5cc16fb1e5c622e6249d97 100644

--- a/components/invalidation/non_blocking_invalidator.h

+++ b/components/invalidation/non_blocking_invalidator.h

@@ -55,7 +55,7 @@ class INVALIDATION_EXPORT_PRIVATE NonBlockingInvalidator

// Invalidator implementation.

void RegisterHandler(InvalidationHandler* handler) override;

- void UpdateRegisteredIds(InvalidationHandler* handler,

+ bool UpdateRegisteredIds(InvalidationHandler* handler,

const ObjectIdSet& ids) override;

void UnregisterHandler(InvalidationHandler* handler) override;

InvalidatorState GetInvalidatorState() const override;

« no previous file with comments | « components/invalidation/invalidator_test_template.h ('k') | components/invalidation/non_blocking_invalidator.cc » ('j') | no next file with comments »