Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: components/invalidation/invalidator_registrar.h

Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from Bartosz. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/invalidation/invalidator.h ('k') | components/invalidation/invalidator_registrar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/invalidation/invalidator_registrar.h
diff --git a/components/invalidation/invalidator_registrar.h b/components/invalidation/invalidator_registrar.h
index e6804bbfb14a82dd22363bc8b54e95215a0f11c8..d0ab22dbafe0435001ca044367b23981354bfc0f 100644
--- a/components/invalidation/invalidator_registrar.h
+++ b/components/invalidation/invalidator_registrar.h
@@ -39,9 +39,9 @@ class INVALIDATION_EXPORT InvalidatorRegistrar {
// Updates the set of ObjectIds associated with |handler|. |handler| must
// not be NULL, and must already be registered. An ID must be registered for
- // at most one handler.
- void UpdateRegisteredIds(InvalidationHandler* handler,
- const ObjectIdSet& ids);
+ // at most one handler. If ID is already registered function returns false.
+ bool UpdateRegisteredIds(InvalidationHandler* handler,
+ const ObjectIdSet& ids) WARN_UNUSED_RESULT;
// Stops sending notifications to |handler|. |handler| must not be NULL, and
// it must already be registered. Note that this doesn't unregister the IDs
« no previous file with comments | « components/invalidation/invalidator.h ('k') | components/invalidation/invalidator_registrar.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698