Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: components/invalidation/invalidation_service.h

Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from Bartosz. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/invalidation/invalidation_service.h
diff --git a/components/invalidation/invalidation_service.h b/components/invalidation/invalidation_service.h
index bf7a23d3e06bdea1b921b96308a0be8eedd8351e..116694de7fd887f682356076d0b061cf2bcd11f5 100644
--- a/components/invalidation/invalidation_service.h
+++ b/components/invalidation/invalidation_service.h
@@ -76,12 +76,12 @@ class InvalidationService {
// Updates the set of ObjectIds associated with |handler|. |handler| must
// not be NULL, and must already be registered. An ID must be registered for
- // at most one handler.
+ // at most one handler. If ID is already registered function returns false.
//
// Registered IDs are persisted across restarts of sync.
- virtual void UpdateRegisteredInvalidationIds(
+ virtual bool UpdateRegisteredInvalidationIds(
syncer::InvalidationHandler* handler,
- const syncer::ObjectIdSet& ids) = 0;
+ const syncer::ObjectIdSet& ids) WARN_UNUSED_RESULT = 0;
// Stops sending notifications to |handler|. |handler| must not be NULL, and
// it must already be registered. Note that this doesn't unregister the IDs
« no previous file with comments | « components/invalidation/invalidation_notifier.cc ('k') | components/invalidation/invalidation_service_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698