chrome/browser/sync/test/integration/fake_server_invalidation_service.cc - Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/fake_server_invalidation_service.cc

Issue 1146533005: [Sync] InvalidationService shouldn't CHECK when registering ObjectId for more than one handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from Bartosz. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/fake_server_invalidation_service.h ('k') | components/invalidation/fake_invalidator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/fake_server_invalidation_service.cc

diff --git a/chrome/browser/sync/test/integration/fake_server_invalidation_service.cc b/chrome/browser/sync/test/integration/fake_server_invalidation_service.cc

index 3324d0c2ed3a242fb4098ade63e1a46764d32411..ce2b3a56df6ef7d6981dfc4cf079032f4face026 100644

--- a/chrome/browser/sync/test/integration/fake_server_invalidation_service.cc

+++ b/chrome/browser/sync/test/integration/fake_server_invalidation_service.cc

@@ -30,10 +30,10 @@ void FakeServerInvalidationService::RegisterInvalidationHandler(

invalidator_registrar_.RegisterHandler(handler);

}

-void FakeServerInvalidationService::UpdateRegisteredInvalidationIds(

+bool FakeServerInvalidationService::UpdateRegisteredInvalidationIds(

syncer::InvalidationHandler* handler,

const syncer::ObjectIdSet& ids) {

- invalidator_registrar_.UpdateRegisteredIds(handler, ids);

+ return invalidator_registrar_.UpdateRegisteredIds(handler, ids);

}

void FakeServerInvalidationService::UnregisterInvalidationHandler(